Skip to content

Commit 0c0d240

Browse files
sammy-SCfacebook-github-bot
authored andcommitted
Make NativeAnimatedNodesManagerProvider not virtual (#51609)
Summary: Pull Request resolved: #51609 changelog: [internal] NativeAnimatedNodesManagerProvider is not subclassed. Let's remove virtual methods and make it a final class. Reviewed By: lenaic Differential Revision: D75169108 fbshipit-source-id: 32121cf372ba94c8a7b86c61fd96efd75560f789
1 parent a314e34 commit 0c0d240

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManagerProvider.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ class NativeAnimatedNodesManagerProvider {
3535
NativeAnimatedNodesManager::StopOnRenderCallback stopOnRenderCallback =
3636
nullptr);
3737

38-
virtual ~NativeAnimatedNodesManagerProvider() = default;
39-
40-
virtual std::shared_ptr<NativeAnimatedNodesManager> getOrCreate(
38+
std::shared_ptr<NativeAnimatedNodesManager> getOrCreate(
4139
jsi::Runtime& runtime);
4240

4341
std::shared_ptr<NativeAnimatedNodesManager> get() {
@@ -50,7 +48,7 @@ class NativeAnimatedNodesManagerProvider {
5048

5149
std::shared_ptr<EventEmitterListener> getEventEmitterListener();
5250

53-
protected:
51+
private:
5452
std::shared_ptr<NativeAnimatedNodesManager> nativeAnimatedNodesManager_;
5553
std::weak_ptr<UIManagerBinding> uiManagerBinding_;
5654

0 commit comments

Comments
 (0)