use folly::dynamic without std::optional (#51605)

Summary:
Pull Request resolved: #51605

changelog: [internal]

folly::dynamic can be constructed with nullptr and it creates a null folly::dynamic. Let's use that to indicate missing value instead of std::optional to lower C++ binary size.

Reviewed By: rshest

Differential Revision: D75174590

fbshipit-source-id: f2dfef00975686f6ac4c14b42539e700e967075b

Author: sammy-SC

packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedMountingOverrideDelegate.cpp

@@ -14,7 +14,7 @@
 namespace facebook::react {
 
 AnimatedMountingOverrideDelegate::AnimatedMountingOverrideDelegate(
-    std::function<std::optional<folly::dynamic>(Tag)> getAnimatedManagedProps,
+    std::function<folly::dynamic(Tag)> getAnimatedManagedProps,
     std::weak_ptr<UIManagerBinding> uiManagerBinding)
     : MountingOverrideDelegate(),
       getAnimatedManagedProps_(std::move(getAnimatedManagedProps)),
@@ -39,8 +39,9 @@ AnimatedMountingOverrideDelegate::pullTransaction(
   for (const auto& mutation : mutations) {
     if (mutation.type == ShadowViewMutation::Update) {
       const auto tag = mutation.newChildShadowView.tag;
-      if (auto props = getAnimatedManagedProps_(tag)) {
-        animatedManagedProps.insert({tag, std::move(*props)});
+      auto props = getAnimatedManagedProps_(tag);
+      if (!props.isNull()) {
+        animatedManagedProps.insert({tag, std::move(props)});
       }
     }
   }

packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedMountingOverrideDelegate.h

@@ -22,7 +22,7 @@ class UIManagerBinding;
 class AnimatedMountingOverrideDelegate : public MountingOverrideDelegate {
  public:
   AnimatedMountingOverrideDelegate(
-      std::function<std::optional<folly::dynamic>(Tag)> getAnimatedManagedProps,
+      std::function<folly::dynamic(Tag)> getAnimatedManagedProps,
       std::weak_ptr<UIManagerBinding> uiManagerBinding);
 
   bool shouldOverridePullTransaction() const override;
@@ -34,7 +34,7 @@ class AnimatedMountingOverrideDelegate : public MountingOverrideDelegate {
       ShadowViewMutationList mutations) const override;
 
  private:
-  std::function<std::optional<folly::dynamic>(Tag)> getAnimatedManagedProps_;
+  std::function<folly::dynamic(Tag)> getAnimatedManagedProps_;
 
   std::weak_ptr<UIManagerBinding> uiManagerBinding_;
 };

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -640,8 +640,7 @@ bool NativeAnimatedNodesManager::onAnimationFrame(uint64_t timestamp) {
   return commitProps();
 }
 
-std::optional<folly::dynamic> NativeAnimatedNodesManager::managedProps(
-    Tag tag) noexcept {
+folly::dynamic NativeAnimatedNodesManager::managedProps(Tag tag) noexcept {
   std::lock_guard<std::mutex> lock(connectedAnimatedNodesMutex_);
   const auto iter = connectedAnimatedNodes_.find(tag);
   if (iter != connectedAnimatedNodes_.end()) {
@@ -650,7 +649,7 @@ std::optional<folly::dynamic> NativeAnimatedNodesManager::managedProps(
     }
   }
 
-  return {};
+  return nullptr;
 }
 
 bool NativeAnimatedNodesManager::isOnRenderThread() const noexcept {

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h

@@ -160,7 +160,7 @@ class NativeAnimatedNodesManager {
   void updateNodes(
       const std::set<int>& finishedAnimationValueNodes = {}) noexcept;
 
-  std::optional<folly::dynamic> managedProps(Tag tag) noexcept;
+  folly::dynamic managedProps(Tag tag) noexcept;
 
   bool isOnRenderThread() const noexcept;
 

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManagerProvider.cpp

@@ -100,12 +100,12 @@ NativeAnimatedNodesManagerProvider::getOrCreate(jsi::Runtime& runtime) {
               [nativeAnimatedNodesManager =
                    std::weak_ptr<NativeAnimatedNodesManager>(
                        nativeAnimatedNodesManager_)](
-                  Tag tag) -> std::optional<folly::dynamic> {
+                  Tag tag) -> folly::dynamic {
                 if (auto nativeAnimatedNodesManagerStrong =
                         nativeAnimatedNodesManager.lock()) {
                   return nativeAnimatedNodesManagerStrong->managedProps(tag);
                 }
-                return std::nullopt;
+                return nullptr;
               },
               uiManagerBinding_);