Back out "add 'as const' annotations in preparation of natural inference rollout in xplat/js [4/n]"

Summary:
Original commit changeset: 67ee5673816d

Original Phabricator Diff: D75114154

Reviewed By: SamChou19815

Differential Revision: D75161840

fbshipit-source-id: 144fc0e488154b957f4f2a549c077a2784124849

Author: panagosg7

packages/react-native-babel-transformer/src/index.js

@@ -190,7 +190,7 @@ const transform /*: BabelTransformer['transform'] */ = ({
   try {
     const babelConfig = {
       // ES modules require sourceType='module' but OSS may not always want that
-      sourceType: 'unambiguous' as const,
+      sourceType: 'unambiguous',
       ...buildBabelConfig(filename, options, plugins),
       caller: {name: 'metro', bundler: 'metro', platform: options.platform},
       ast: true,

packages/react-native-compatibility-check/src/VersionDiffing.js

@@ -977,14 +977,14 @@ function buildNativeModulesDiff(
   );
 
   const newType = {
-    type: 'ObjectTypeAnnotation' as const,
+    type: 'ObjectTypeAnnotation',
     properties: [
       ...newerNativeModule.spec.methods,
       ...newerNativeModule.spec.eventEmitters,
     ],
   };
   const oldType = {
-    type: 'ObjectTypeAnnotation' as const,
+    type: 'ObjectTypeAnnotation',
     properties: [
       ...olderNativeModule.spec.methods,
       ...olderNativeModule.spec.eventEmitters,
@@ -1074,13 +1074,13 @@ function buildNativeComponentsDiff(
         );
 
         const newCommands = {
-          type: 'ObjectTypeAnnotation' as const,
+          type: 'ObjectTypeAnnotation',
           properties: [command],
         };
         const oldCommands =
           oldCommand != null
             ? {
-                type: 'ObjectTypeAnnotation' as const,
+                type: 'ObjectTypeAnnotation',
                 properties: [oldCommand],
               }
             : null;
@@ -1124,15 +1124,15 @@ function buildNativeComponentsDiff(
       // We have to do this to remove the .defaults from the props and get it into
       // standard JavaScript shapes.
       const newConvertedProps = {
-        type: 'ObjectTypeAnnotation' as const,
+        type: 'ObjectTypeAnnotation',
         properties: newerComponent.props.map(prop => ({
           name: prop.name,
           optional: prop.optional,
           typeAnnotation: convertPropToBasicTypes(prop.typeAnnotation),
         })),
       };
       const oldConvertedProps = {
-        type: 'ObjectTypeAnnotation' as const,
+        type: 'ObjectTypeAnnotation',
         properties: olderComponent.props.map(prop => ({
           name: prop.name,
           optional: prop.optional,

packages/react-native-fantom/runner/runner.js

@@ -74,8 +74,8 @@ async function processRNTesterCommandResult(
       parsed = JSON.parse(line);
     } catch {
       parsed = {
-        type: 'console-log' as const,
-        level: 'info' as const,
+        type: 'console-log',
+        level: 'info',
         message: line,
       };
     }

packages/react-native-fantom/runtime/setup.js

@@ -331,10 +331,10 @@ function runSpec(spec: Spec): TestCaseResult {
     spec.implementation();
     invokeHooks(spec.parentContext, 'afterEachHooks');
 
-    status = 'passed' as const;
+    status = 'passed';
   } catch (e) {
     error = e;
-    status = 'failed' as const;
+    status = 'failed';
   }
 
   result.status = status;

packages/react-native/Libraries/Modal/Modal.js

@@ -279,7 +279,7 @@ class Modal extends React.Component<ModalProps, ModalState> {
           : this.props.backdropColor ?? 'white',
     };
 
-    let animationType = this.props.animationType || ('none' as const);
+    let animationType = this.props.animationType || 'none';
 
     let presentationStyle = this.props.presentationStyle;
     if (!presentationStyle) {

packages/react-native/Libraries/NativeComponent/__tests__/StaticViewConfigValidator-test.js

@@ -40,11 +40,11 @@ test('passes for identical configs', () => {
     },
     uiViewClassName: 'RCTView',
     validAttributes: {
-      collapsable: true as const,
-      nativeID: true as const,
+      collapsable: true,
+      nativeID: true,
       style: {
-        height: true as const,
-        width: true as const,
+        height: true,
+        width: true,
       },
     },
   };
@@ -70,11 +70,11 @@ test('passes for identical configs', () => {
     },
     uiViewClassName: 'RCTView',
     validAttributes: {
-      collapsable: true as const,
-      nativeID: true as const,
+      collapsable: true,
+      nativeID: true,
       style: {
-        height: true as const,
-        width: true as const,
+        height: true,
+        width: true,
       },
     },
   };
@@ -190,11 +190,11 @@ test('allows static viewconfigs to have more properties than native viewconfigs'
   const staticViewConfig = {
     uiViewClassName: 'RCTView',
     validAttributes: {
-      collapsable: true as const,
-      nativeID: true as const,
+      collapsable: true,
+      nativeID: true,
       style: {
-        height: true as const,
-        width: true as const,
+        height: true,
+        width: true,
       },
     },
   };

packages/react-native/Libraries/Text/Text.js

@@ -541,10 +541,10 @@ const userSelectToSelectableMap = {
 };
 
 const verticalAlignToTextAlignVerticalMap = {
-  auto: 'auto' as const,
-  top: 'top' as const,
-  bottom: 'bottom' as const,
-  middle: 'center' as const,
+  auto: 'auto',
+  top: 'top',
+  bottom: 'bottom',
+  middle: 'center',
 };
 
 export default TextImpl;

packages/react-native/Libraries/Text/TextNativeComponent.js

@@ -30,23 +30,23 @@ export type NativeTextProps = $ReadOnly<{
 
 const textViewConfig = {
   validAttributes: {
-    isHighlighted: true as const,
-    isPressable: true as const,
-    numberOfLines: true as const,
-    ellipsizeMode: true as const,
-    allowFontScaling: true as const,
-    dynamicTypeRamp: true as const,
-    maxFontSizeMultiplier: true as const,
-    disabled: true as const,
-    selectable: true as const,
-    selectionColor: true as const,
-    adjustsFontSizeToFit: true as const,
-    minimumFontScale: true as const,
-    textBreakStrategy: true as const,
-    onTextLayout: true as const,
-    dataDetectorType: true as const,
-    android_hyphenationFrequency: true as const,
-    lineBreakStrategyIOS: true as const,
+    isHighlighted: true,
+    isPressable: true,
+    numberOfLines: true,
+    ellipsizeMode: true,
+    allowFontScaling: true,
+    dynamicTypeRamp: true,
+    maxFontSizeMultiplier: true,
+    disabled: true,
+    selectable: true,
+    selectionColor: true,
+    adjustsFontSizeToFit: true,
+    minimumFontScale: true,
+    textBreakStrategy: true,
+    onTextLayout: true,
+    dataDetectorType: true,
+    android_hyphenationFrequency: true,
+    lineBreakStrategyIOS: true,
   },
   directEventTypes: {
     topTextLayout: {
@@ -58,9 +58,9 @@ const textViewConfig = {
 
 const virtualTextViewConfig = {
   validAttributes: {
-    isHighlighted: true as const,
-    isPressable: true as const,
-    maxFontSizeMultiplier: true as const,
+    isHighlighted: true,
+    isPressable: true,
+    maxFontSizeMultiplier: true,
   },
   uiViewClassName: 'RCTVirtualText',
 };

packages/react-native/scripts/ios-prebuild/hermes.js

@@ -97,10 +97,9 @@ type HermesEngineSourceType =
 */
 
 const HermesEngineSourceTypes = {
-  LOCAL_PREBUILT_TARBALL: 'local_prebuilt_tarball' as const,
-  DOWNLOAD_PREBUILD_TARBALL: 'download_prebuild_tarball' as const,
-  DOWNLOAD_PREBUILT_NIGHTLY_TARBALL:
-    'download_prebuilt_nightly_tarball' as const,
+  LOCAL_PREBUILT_TARBALL: 'local_prebuilt_tarball',
+  DOWNLOAD_PREBUILD_TARBALL: 'download_prebuild_tarball',
+  DOWNLOAD_PREBUILT_NIGHTLY_TARBALL: 'download_prebuilt_nightly_tarball',
 };
 
 /**

packages/react-native/src/private/animated/__tests__/createAnimatedPropsMemoHook-test.js

@@ -20,10 +20,10 @@ describe('createCompositeKeyForProps', () => {
     it('excludes non-array and non-object allowlisted props', () => {
       const props = {string: 'abc', number: 123, boolean: true, function() {}};
       const allowlist = {
-        string: true as const,
-        number: true as const,
-        boolean: true as const,
-        function: true as const,
+        string: true,
+        number: true,
+        boolean: true,
+        function: true,
       };
       const compositeKey = createCompositeKeyForProps(props, allowlist);
 
@@ -53,7 +53,7 @@ describe('createCompositeKeyForProps', () => {
         bar: new AnimatedEvent([], {useNativeDriver: true}),
       };
       const allowlist = {
-        bar: true as const,
+        bar: true,
       };
       const compositeKey = createCompositeKeyForProps(props, allowlist);
 
@@ -70,7 +70,7 @@ describe('createCompositeKeyForProps', () => {
       };
       const allowlist = {
         style: {
-          baz: true as const,
+          baz: true,
         },
       };
       const compositeKey = createCompositeKeyForProps(props, allowlist);
@@ -84,7 +84,7 @@ describe('createCompositeKeyForProps', () => {
         bar: new AnimatedValue(1),
       };
       const allowlist = {
-        bar: true as const,
+        bar: true,
       };
       const compositeKey = createCompositeKeyForProps(props, allowlist);
 
@@ -108,7 +108,7 @@ describe('createCompositeKeyForProps', () => {
       const props = {
         style: {opacity, transform: [{rotateX: 1}, {rotateY}, {rotateZ: 1}]},
       };
-      const allowlist = {style: {transform: true as const}};
+      const allowlist = {style: {transform: true}};
       const compositeKey = createCompositeKeyForProps(props, allowlist);
 
       expect(compositeKey).toEqual({
@@ -126,7 +126,7 @@ describe('createCompositeKeyForProps', () => {
       const props = {
         style: [{opacity: opacityA}, {opacity: opacityB}],
       };
-      const allowlist = {style: {opacity: true as const}};
+      const allowlist = {style: {opacity: true}};
       const compositeKey = createCompositeKeyForProps(props, allowlist);
 
       expect(compositeKey).toEqual({style: {opacity: opacityB}});