Align with GH Actions namings (#55469)

Summary:
Pull Request resolved: #55469

Rename workflow job IDs from kebab-case to snake_case and update workflow name to match convention.

Changelog: [General][Changed] - rename workflow job IDs from kebab-case to snake_case

Reviewed By: huntie

Differential Revision: D92697078

fbshipit-source-id: bc8c99b6807997fe625d1f7921b3664992697b36

Author: emily8rown

.github/workflows/analyze-pr.yml

@@ -9,7 +9,7 @@ permissions:
   issues: write
 
 jobs:
-  analyze-pr:
+  analyze_pr:
     runs-on: ubuntu-latest
     if: github.repository == 'facebook/react-native'
     steps:

.github/workflows/api-changes.yml

@@ -1,4 +1,4 @@
-name: Validate API snapshot changes
+name: Analyze API Changes
 
 on:
   pull_request_target:
@@ -8,7 +8,7 @@ permissions:
   pull-requests: write
 
 jobs:
-  api-changes:
+  api_changes:
     runs-on: ubuntu-latest
     if: github.repository == 'facebook/react-native'
     steps: