Skip to content

Commit 22b8b53

Browse files
NSProgrammerfacebook-github-bot
authored andcommitted
Fix exhaustive switches (#52383)
Summary: Pull Request resolved: #52383 Changelog: [General][Fixed] - Add `default:` case to avoid warnings/errors for targets that compile with `-Wswitch-enum` and `-Wswitch-default` enabled Reviewed By: aary Differential Revision: D77051150 fbshipit-source-id: a4f18bb7e47f027fd64cc42bacd7246263ef2454
1 parent 9079b53 commit 22b8b53

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

packages/react-native/Libraries/Image/RCTResizeMode.h

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,12 @@ static inline RCTResizeMode RCTResizeModeFromUIViewContentMode(UIViewContentMode
2121
switch (mode) {
2222
case UIViewContentModeScaleToFill:
2323
return RCTResizeModeStretch;
24-
break;
2524
case UIViewContentModeScaleAspectFit:
2625
return RCTResizeModeContain;
27-
break;
2826
case UIViewContentModeScaleAspectFill:
2927
return RCTResizeModeCover;
30-
break;
31-
case UIViewContentModeCenter:
32-
return RCTResizeModeCenter;
33-
break;
3428
case UIViewContentModeTopLeft:
3529
return RCTResizeModeNone;
36-
break;
3730
case UIViewContentModeRedraw:
3831
case UIViewContentModeTop:
3932
case UIViewContentModeBottom:
@@ -43,6 +36,9 @@ static inline RCTResizeMode RCTResizeModeFromUIViewContentMode(UIViewContentMode
4336
case UIViewContentModeBottomLeft:
4437
case UIViewContentModeBottomRight:
4538
return RCTResizeModeRepeat;
39+
case UIViewContentModeCenter:
40+
default:
41+
return RCTResizeModeCenter;
4642
}
4743
};
4844

packages/react-native/React/Base/RCTBridgeMethod.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,13 @@ typedef NS_ENUM(NSInteger, RCTFunctionType) {
1818
static inline const char *RCTFunctionDescriptorFromType(RCTFunctionType type)
1919
{
2020
switch (type) {
21-
case RCTFunctionTypeNormal:
22-
return "async";
2321
case RCTFunctionTypePromise:
2422
return "promise";
2523
case RCTFunctionTypeSync:
2624
return "sync";
25+
case RCTFunctionTypeNormal:
26+
default:
27+
return "async";
2728
}
2829
};
2930

0 commit comments

Comments
 (0)