Skip to content

Commit 254a918

Browse files
cipolleschifacebook-github-bot
authored andcommitted
properly set dependencies on JSI and React-hermes (#51623)
Summary: Pull Request resolved: #51623 This fix relaxes some dependencies on React-hermes that should not be in the code. ## Changelog: [Internal] - Remove dependencies from React-Hermes when they are not needed. Reviewed By: cortinico Differential Revision: D75447910 fbshipit-source-id: 6d7695f0e2b6c936b4c5ed9e70261f1d3b28a3d0
1 parent 2578fd1 commit 254a918

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

packages/react-native/Libraries/AppDelegate/React-RCTAppDelegate.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ Pod::Spec.new do |s|
6666
s.dependency "React-CoreModules"
6767
s.dependency "React-RCTFBReactNativeSpec"
6868
s.dependency "React-defaultsnativemodule"
69+
s.dependency 'React-hermes'
6970

7071
add_dependency(s, "ReactCommon", :subspec => "turbomodule/core", :additional_framework_paths => ["react/nativemodule/core"])
7172
add_dependency(s, "React-NativeModulesApple")

packages/react-native/React-Core.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ Pod::Spec.new do |s|
122122
s.dependency "React-featureflags"
123123
s.dependency "React-runtimescheduler"
124124
s.dependency "Yoga"
125+
s.dependency 'React-hermes'
125126

126127
s.resource_bundles = {'React-Core_privacy' => 'React/Resources/PrivacyInfo.xcprivacy'}
127128

@@ -131,6 +132,7 @@ Pod::Spec.new do |s|
131132
add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
132133
add_dependency(s, "RCTDeprecation")
133134

135+
134136
depend_on_js_engine(s)
135137
add_rn_third_party_dependencies(s)
136138
end

packages/react-native/scripts/cocoapods/jsengine.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ def setup_hermes!(react_native_path: "../node_modules/react-native")
3636
def depend_on_js_engine(s)
3737
if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
3838
s.dependency 'hermes-engine'
39-
s.dependency 'React-hermes'
4039
elsif ENV['USE_THIRD_PARTY_JSC'] != '1'
4140
s.dependency 'React-jsc'
4241
end

0 commit comments

Comments
 (0)