Commit 2bc2c8d
Add local network permission prompt on android 17 (#57291)
Summary:
Android 17 (SDK 37) introduces Local Network Protection. Reaching any local-network address now requires the runtime `ACCESS_LOCAL_NETWORK` permission. This is how the dev server is reached, so on an Android 17 device the dev bundle download is blocked
This adds a debug-only path that requests `ACCESS_LOCAL_NETWORK` before the first bundle load and defers `loadApp` until the user answers, so a slow response can't cause an error
cc zoontek
## Changelog:
[Android] [Fixed] - Request `ACCESS_LOCAL_NETWORK` so the dev server stays reachable on Android 17 (SDK 37)[Android] [Added] - Add `ACCESS_LOCAL_NETWORK` to `PermissionsAndroid`
Pull Request resolved: #57291
Test Plan:
Validated on an Android 17 emulator and physical device.
- **targetSdk 36 and 37**
launch → prompt appears → grant → bundle loads.
Deny → app starts and shows the normal red-box connection error.
- **API 36 / older devices:** no prompt, behavior unchanged.
- **USB device via `adb reverse`:** no prompt (loopback is exempt).
Reviewed By: cortinico, Abbondanzo
Differential Revision: D109160057
Pulled By: fabriziocucci
fbshipit-source-id: 4bbd9a3e97e5d12b8add635ed0daa15f6fe90ce01 parent 2f325e2 commit 2bc2c8d
7 files changed
Lines changed: 75 additions & 6 deletions
File tree
- packages/react-native
- Libraries/PermissionsAndroid
- ReactAndroid/src
- debug
- main/java/com/facebook/react
- devsupport
- util
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
| 62 | + | |
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
| |||
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
119 | | - | |
| 120 | + | |
| 121 | + | |
120 | 122 | | |
121 | 123 | | |
122 | 124 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| 78 | + | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
| |||
125 | 126 | | |
126 | 127 | | |
127 | 128 | | |
| 129 | + | |
128 | 130 | | |
129 | 131 | | |
130 | 132 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
10 | 16 | | |
11 | 17 | | |
12 | 18 | | |
| |||
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
168 | 169 | | |
169 | 170 | | |
170 | 171 | | |
171 | | - | |
| 172 | + | |
| 173 | + | |
172 | 174 | | |
173 | 175 | | |
174 | 176 | | |
| |||
Lines changed: 49 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
3548 | 3548 | | |
3549 | 3549 | | |
3550 | 3550 | | |
| 3551 | + | |
3551 | 3552 | | |
3552 | 3553 | | |
3553 | 3554 | | |
| |||
6053 | 6054 | | |
6054 | 6055 | | |
6055 | 6056 | | |
6056 | | - | |
| 6057 | + | |
6057 | 6058 | | |
6058 | | - | |
| 6059 | + | |
6059 | 6060 | | |
6060 | 6061 | | |
6061 | 6062 | | |
| |||
0 commit comments