Skip to content

Commit 3368e9e

Browse files
fabriziocuccimeta-codesync[bot]
authored andcommitted
Fix IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS value to match HorizonOS API (#55300)
Summary: Pull Request resolved: #55300 Changelog: [Internal] The `IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS` constant was incorrectly set to `0x8`. This value was sourced from the "UI Understanding APIs TDD" design document, which had an outdated/incorrect value. The correct value is `0x4`, as defined in the official HorizonOS API at `horizonos.view.ViewExt.IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS`. References: - Incorrect source (TDD doc): https://docs.google.com/document/d/1YQ5rel1bvZboTfs1-8uPWJnOAyfl_fSm9oILjU-2lbg/edit?tab=t.0 - Correct source (ViewExt.java): https://www.internalfb.com/code/aosp-vendor-meta-coresdk/[oculus-14.0]/api-src/volumetricwindow/java/horizonos/view/ViewExt.java?lines=50 Reviewed By: twasilczyk Differential Revision: D91500494 fbshipit-source-id: fac8546dba193a510c0c2e1badd512126eaf20f8
1 parent 3e62eb8 commit 3368e9e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ImportantForInteractionHelper.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ internal object ImportantForInteractionHelper {
2929
const val IMPORTANT_FOR_INTERACTION_NO: Int = 0x2
3030

3131
/** Descendants of this view should be excluded from interaction handling. */
32-
const val IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS: Int = 0x8
32+
const val IMPORTANT_FOR_INTERACTION_EXCLUDE_DESCENDANTS: Int = 0x4
3333

3434
/**
3535
* Sets the important_for_interaction tag on a view based on the given [PointerEvents] value.

0 commit comments

Comments
 (0)