Skip to content

Commit 3525998

Browse files
Kathy Grayfacebook-github-bot
authored andcommitted
Setup experiment for split packages
Reviewed By: javache Differential Revision: D5314224 fbshipit-source-id: b9bc28b8f4e058db1dcc0c17f7dc84bf15eb33f9
1 parent e301a36 commit 3525998

2 files changed

Lines changed: 11 additions & 3 deletions

File tree

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,8 @@ public static ReactInstanceManagerBuilder builder() {
223223
@Nullable DevBundleDownloadListener devBundleDownloadListener,
224224
boolean setupReactContextInBackgroundEnabled,
225225
boolean useSeparateUIBackgroundThread,
226-
int minNumShakes) {
226+
int minNumShakes,
227+
boolean splitPackagesEnabled) {
227228
Log.d(ReactConstants.TAG, "ReactInstanceManager.ctor()");
228229
initializeSoLoaderIfNecessary(applicationContext);
229230

@@ -256,7 +257,7 @@ public static ReactInstanceManagerBuilder builder() {
256257
mUseSeparateUIBackgroundThread = useSeparateUIBackgroundThread;
257258
mMinNumShakes = minNumShakes;
258259

259-
if (true) { // TODO Change to a QE-determined experiment variable in separate commit
260+
if (!splitPackagesEnabled) {
260261
CoreModulesPackage coreModulesPackage =
261262
new CoreModulesPackage(
262263
this,

ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public class ReactInstanceManagerBuilder {
4747
protected boolean mSetupReactContextInBackground;
4848
protected boolean mUseSeparateUIBackgroundThread;
4949
protected int mMinNumShakes = 1;
50+
protected boolean mEnableSplitPackage;
5051

5152
/* package protected */ ReactInstanceManagerBuilder() {
5253
}
@@ -213,6 +214,11 @@ public ReactInstanceManagerBuilder setMinNumShakes(int minNumShakes) {
213214
return this;
214215
}
215216

217+
public ReactInstanceManagerBuilder setEnableSplitPackage(boolean enableSplitPackage) {
218+
mEnableSplitPackage = enableSplitPackage;
219+
return this;
220+
}
221+
216222
/**
217223
* Instantiates a new {@link ReactInstanceManager}.
218224
* Before calling {@code build}, the following must be called:
@@ -262,6 +268,7 @@ public ReactInstanceManager build() {
262268
mDevBundleDownloadListener,
263269
mSetupReactContextInBackground,
264270
mUseSeparateUIBackgroundThread,
265-
mMinNumShakes);
271+
mMinNumShakes,
272+
mEnableSplitPackage);
266273
}
267274
}

0 commit comments

Comments
 (0)