Skip to content

Commit 38e3075

Browse files
fabriziocuccimeta-codesync[bot]
authored andcommitted
Override default value for shouldUseLinkRoleForPressableText and shouldSetEnabledBasedOnAccessibilityState (#54531)
Summary: Pull Request resolved: #54531 Changelog: [Android][Changed] - Enabled shouldUseLinkRoleForPressableText and shouldSetEnabledBasedOnAccessibilityState feature flags by default to improve accessibility behavior. Reviewed By: javache Differential Revision: D86961734 fbshipit-source-id: e011c29faca8277f95bccf71c6b5b96793504ef4
1 parent 970560c commit 38e3075

4 files changed

Lines changed: 11 additions & 13 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<a388c8e701ece8b9ea1dc23915a09399>>
7+
* @generated SignedSource<<4b24bc3165b6ab1583efc8e1a22444ed>>
88
*/
99

1010
/**
@@ -161,7 +161,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
161161

162162
override fun shouldPressibilityUseW3CPointerEventsForHover(): Boolean = false
163163

164-
override fun shouldSetEnabledBasedOnAccessibilityState(): Boolean = false
164+
override fun shouldSetEnabledBasedOnAccessibilityState(): Boolean = true
165165

166166
override fun shouldTriggerResponderTransferOnScrollAndroid(): Boolean = false
167167

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<cee8df221e101e8261e65dacd9231145>>
7+
* @generated SignedSource<<18c966119a9b6123aea3b088e0eaf98b>>
88
*/
99

1010
/**
@@ -304,7 +304,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
304304
}
305305

306306
bool shouldSetEnabledBasedOnAccessibilityState() override {
307-
return false;
307+
return true;
308308
}
309309

310310
bool shouldTriggerResponderTransferOnScrollAndroid() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -785,13 +785,12 @@ const definitions: FeatureFlagDefinitions = {
785785
ossReleaseStage: 'none',
786786
},
787787
shouldSetEnabledBasedOnAccessibilityState: {
788-
defaultValue: false,
788+
defaultValue: true,
789789
metadata: {
790-
dateAdded: '2025-11-11',
791790
description:
792791
'Fix BaseViewManager to properly set view.setEnabled() based on accessibilityState.disabled.',
793792
expectedReleaseValue: true,
794-
purpose: 'experimentation',
793+
purpose: 'release',
795794
},
796795
ossReleaseStage: 'none',
797796
},
@@ -1108,13 +1107,12 @@ const definitions: FeatureFlagDefinitions = {
11081107
ossReleaseStage: 'none',
11091108
},
11101109
shouldUseLinkRoleForPressableText: {
1111-
defaultValue: false,
1110+
defaultValue: true,
11121111
metadata: {
1113-
dateAdded: '2025-11-10',
11141112
description:
11151113
'Set accessibilityRole to "link" for pressable Text components by default.',
11161114
expectedReleaseValue: true,
1117-
purpose: 'experimentation',
1115+
purpose: 'release',
11181116
},
11191117
ossReleaseStage: 'none',
11201118
},

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<6aa0feb805c07564631370eb30b4bc9e>>
7+
* @generated SignedSource<<312e7dcaaaf8bade0acf80d15e8eedee>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -204,7 +204,7 @@ export const shouldUseAnimatedObjectForTransform: Getter<boolean> = createJavaSc
204204
/**
205205
* Set accessibilityRole to "link" for pressable Text components by default.
206206
*/
207-
export const shouldUseLinkRoleForPressableText: Getter<boolean> = createJavaScriptFlagGetter('shouldUseLinkRoleForPressableText', false);
207+
export const shouldUseLinkRoleForPressableText: Getter<boolean> = createJavaScriptFlagGetter('shouldUseLinkRoleForPressableText', true);
208208

209209
/**
210210
* removeClippedSubviews prop will be used as the default in FlatList on iOS to match Android
@@ -504,7 +504,7 @@ export const shouldPressibilityUseW3CPointerEventsForHover: Getter<boolean> = cr
504504
/**
505505
* Fix BaseViewManager to properly set view.setEnabled() based on accessibilityState.disabled.
506506
*/
507-
export const shouldSetEnabledBasedOnAccessibilityState: Getter<boolean> = createNativeFlagGetter('shouldSetEnabledBasedOnAccessibilityState', false);
507+
export const shouldSetEnabledBasedOnAccessibilityState: Getter<boolean> = createNativeFlagGetter('shouldSetEnabledBasedOnAccessibilityState', true);
508508
/**
509509
* Do not emit touchcancel from Android ScrollView, instead native topScroll event will trigger responder transfer and terminate in RN renderer.
510510
*/

0 commit comments

Comments
 (0)