Skip to content

Commit 3a4d79e

Browse files
cortinicohuntie
authored andcommitted
Fix broken Loading/Refreshing indicator on Android
Summary: The Loading.../Refreshing... indicator is currently broken on Android. The reason is related to D42599220 We used to have a Toast shown to users on Android as a fallback, but as the DevLoadingView is not always loaded as a module in the core package, this ends up in the banner never beign shown to the user (on RN Tester or template apps). Changelog: [Android] [Fixed] - Fix broken Loading/Refreshing indicator on Android Reviewed By: cipolleschi Differential Revision: D49876757 fbshipit-source-id: 400e002327ebca908e3e7a7f81c5066888ac4e9b
1 parent e031c05 commit 3a4d79e

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import com.facebook.react.modules.blob.FileReaderModule;
2626
import com.facebook.react.modules.camera.ImageStoreManager;
2727
import com.facebook.react.modules.clipboard.ClipboardModule;
28+
import com.facebook.react.modules.devloading.DevLoadingModule;
2829
import com.facebook.react.modules.devtoolssettings.DevToolsSettingsManagerModule;
2930
import com.facebook.react.modules.dialog.DialogModule;
3031
import com.facebook.react.modules.fresco.FrescoModule;
@@ -72,6 +73,7 @@
7273
AppearanceModule.class,
7374
AppStateModule.class,
7475
BlobModule.class,
76+
DevLoadingModule.class,
7577
FileReaderModule.class,
7678
ClipboardModule.class,
7779
DialogModule.class,
@@ -113,6 +115,8 @@ public MainReactPackage(MainPackageConfig config) {
113115
return new AppStateModule(context);
114116
case BlobModule.NAME:
115117
return new BlobModule(context);
118+
case DevLoadingModule.NAME:
119+
return new DevLoadingModule(context);
116120
case FileReaderModule.NAME:
117121
return new FileReaderModule(context);
118122
case ClipboardModule.NAME:
@@ -371,6 +375,7 @@ public ReactModuleInfoProvider getReactModuleInfoProvider() {
371375
AppearanceModule.class,
372376
AppStateModule.class,
373377
BlobModule.class,
378+
DevLoadingModule.class,
374379
FileReaderModule.class,
375380
ClipboardModule.class,
376381
DialogModule.class,

0 commit comments

Comments
 (0)