Skip to content

Commit 4365c1c

Browse files
SamChou19815facebook-github-bot
authored andcommitted
Cleanup codeless suppressions in xplat/js (#53573)
Summary: Pull Request resolved: #53573 Changelog: [Internal] Reviewed By: marcoww6 Differential Revision: D81552699 fbshipit-source-id: 71b104174a8ad7fbf360cdd87109ce034f49ec70
1 parent f33a1cd commit 4365c1c

8 files changed

Lines changed: 1 addition & 13 deletions

File tree

packages/community-cli-plugin/src/utils/version.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ Diff: ${styleText(['dim', 'underline'], newVersion?.diffUrl ?? 'none')}
8888
}
8989
}
9090

91-
// $FlowFixMe
9291
function isDiffPurgeEntry(data: Partial<DiffPurge>): data is DiffPurge {
9392
return (
9493
// $FlowFixMe[incompatible-type-guard]

packages/react-native/Libraries/Lists/__flowtests__/SectionList-flowtest.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ export function testBadSectionsShape(): React.MixedElement {
102102
],
103103
},
104104
];
105-
// $FlowExpectedError - section missing `data` field
106105
return <SectionList renderItem={renderMyListItem} sections={sections} />;
107106
}
108107

packages/react-native/Libraries/Network/XMLHttpRequest.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -649,8 +649,6 @@ class XMLHttpRequest extends EventTarget {
649649
this._url,
650650
this._headers,
651651
data,
652-
/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was found
653-
* when making Flow check .android.js files. */
654652
nativeResponseType,
655653
incrementalEvents,
656654
this.timeout,

packages/react-native/Libraries/StyleSheet/__flowtests__/StyleSheet-flowtest.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,7 @@ export function testBadCompose() {
4141
(StyleSheet.compose(textStyle, textStyle): ImageStyleProp);
4242

4343
// $FlowExpectedError[incompatible-type] - Incompatible type.
44-
(StyleSheet.compose(
45-
// $FlowExpectedError - Incompatible type.
46-
[textStyle],
47-
null,
48-
): ImageStyleProp);
44+
(StyleSheet.compose([textStyle], null): ImageStyleProp);
4945

5046
// $FlowExpectedError[incompatible-type] - Incompatible type.
5147
(StyleSheet.compose(

packages/rn-tester/js/examples/DrawerLayoutAndroid/DrawerLayoutAndroidExample.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ const Drawer = () => {
4848

4949
return (
5050
<DrawerLayoutAndroid
51-
/* $FlowFixMe */
5251
ref={drawer}
5352
accessibilityRole="drawerlayout"
5453
drawerWidth={300}

packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPointerOverOut.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ function getNativeTagFromHostElement(elem: ?HostInstance | number): ?number {
2121
return elem;
2222
}
2323
if (elem != null) {
24-
// $FlowExpectedError - accessing non-public property
2524
return elem.__nativeTag;
2625
}
2726
return undefined;

packages/rn-tester/scripts/utils.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ export function observe(result: ExecaPromiseMetaized): TaskResult<{}, string> {
7070
};
7171
});
7272

73-
// $FlowFixMe
7473
return obs;
7574
}
7675

private/helloworld/lib/cli.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ export function observe(result: ExecaPromiseMetaized): TaskResult<{}, string> {
7070
};
7171
});
7272

73-
// $FlowFixMe
7473
return obs;
7574
}
7675

0 commit comments

Comments
 (0)