avoid excessive logs in C++ Animated (#52992)

Summary:
Pull Request resolved: #52992

changelog: [internal]

do not log on every frame to make logs more readable. The callbacks are only set during construction and there is no value in logging on every commit props.

Reviewed By: rshest

Differential Revision: D79436988

fbshipit-source-id: 26c6cbadd5ae0efa8575c7f85e4c0d90e2ef6215

Author: sammy-SC

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -71,7 +71,22 @@ NativeAnimatedNodesManager::NativeAnimatedNodesManager(
     : directManipulationCallback_(std::move(directManipulationCallback)),
       fabricCommitCallback_(std::move(fabricCommitCallback)),
       startOnRenderCallback_(std::move(startOnRenderCallback)),
-      stopOnRenderCallback_(std::move(stopOnRenderCallback)) {}
+      stopOnRenderCallback_(std::move(stopOnRenderCallback)) {
+  if (!fabricCommitCallback_) {
+    LOG(WARNING)
+        << "C++ Animated was setup without commit callback. This may lead to issue where buttons are not tappable when animation is driven by onScroll event.";
+  }
+
+  if (!directManipulationCallback_) {
+    LOG(WARNING)
+        << "C++ Animated was setup without direct manipulation callback. This may lead to suboptimal performance.";
+  }
+
+  if (!directManipulationCallback_ && fabricCommitCallback_) {
+    LOG(ERROR)
+        << "C++ Animated was setup without a way to update UI. Animations will not work.";
+  }
+}
 
 NativeAnimatedNodesManager::~NativeAnimatedNodesManager() noexcept {
   stopRenderCallbackIfNeeded();
@@ -876,23 +891,19 @@ bool NativeAnimatedNodesManager::commitProps() {
   if (fabricCommitCallback_ != nullptr) {
     if (!updateViewProps_.empty()) {
       fabricCommitCallback_(updateViewProps_);
-      updateViewProps_.clear();
     }
-  } else {
-    LOG(ERROR)
-        << "Failed to commit native animation, since Fabric commit callback is not set";
   }
 
+  updateViewProps_.clear();
+
   if (directManipulationCallback_ != nullptr) {
     for (const auto& [viewTag, props] : updateViewPropsDirect_) {
       directManipulationCallback_(viewTag, folly::dynamic(props));
     }
-    updateViewPropsDirect_.clear();
-  } else {
-    LOG(ERROR)
-        << "Failed to commit native animation, since direct manipulation callback is not set";
   }
 
+  updateViewPropsDirect_.clear();
+
   return containsChange;
 }