fix(spm): avoid running codegen config and template install twice per sync

sync-spm-autolinking.js regenerated autolinking.json itself, even though
setup-apple-spm.js already generates it right before calling the sync. This
ran the slow `@react-native-community/cli config` crawl twice, and ran codegen
before the refresh — so it could reuse a stale autolinking.json and miss a
newly installed native lib's codegen specs.

Now the config runs once (in the caller), codegen reuses its fresh output, and
the codegen template is installed only once, after the xcframework symlinks
are repointed.

Author: chrfalch

packages/react-native/scripts/spm/__tests__/spm-utils-test.js

@@ -16,6 +16,7 @@ const {
   makeLogger,
   readPackageJson,
   resolveReactNativeRoot,
+  runCodegenAndInstallTemplate,
   toSwiftName,
 } = require('../spm-utils');
 const fs = require('fs');
@@ -217,3 +218,73 @@ describe('resolveReactNativeRoot', () => {
     ).toBe(rnRoot);
   });
 });
+
+// ---------------------------------------------------------------------------
+// runCodegenAndInstallTemplate
+// ---------------------------------------------------------------------------
+
+describe('runCodegenAndInstallTemplate', () => {
+  let tempDir;
+  let reactNativeRoot;
+  let appRoot;
+  let codegenPkgSwift;
+
+  beforeEach(() => {
+    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'spm-codegen-test-'));
+    reactNativeRoot = path.join(tempDir, 'react-native');
+    appRoot = path.join(tempDir, 'app');
+
+    // Minimal fake codegen script (no-op) so the execSync call exits cleanly.
+    fs.mkdirSync(path.join(reactNativeRoot, 'scripts'), {recursive: true});
+    fs.writeFileSync(
+      path.join(reactNativeRoot, 'scripts', 'generate-codegen-artifacts.js'),
+      '// no-op codegen for tests\n',
+    );
+    // Codegen template that installSpmCodegenTemplate renders + writes.
+    fs.mkdirSync(
+      path.join(reactNativeRoot, 'scripts', 'codegen', 'templates'),
+      {
+        recursive: true,
+      },
+    );
+    fs.writeFileSync(
+      path.join(
+        reactNativeRoot,
+        'scripts',
+        'codegen',
+        'templates',
+        'Package.swift.spm-template',
+      ),
+      '// template\n',
+    );
+    // build/generated/ios must exist for the template to be installed.
+    fs.mkdirSync(path.join(appRoot, 'build', 'generated', 'ios'), {
+      recursive: true,
+    });
+    codegenPkgSwift = path.join(
+      appRoot,
+      'build',
+      'generated',
+      'ios',
+      'Package.swift',
+    );
+  });
+
+  afterEach(() => {
+    fs.rmSync(tempDir, {recursive: true, force: true});
+  });
+
+  it('installs the codegen template by default', () => {
+    runCodegenAndInstallTemplate(appRoot, appRoot, reactNativeRoot);
+    expect(fs.existsSync(codegenPkgSwift)).toBe(true);
+  });
+
+  it('skips the template install when installTemplate is false', () => {
+    runCodegenAndInstallTemplate(appRoot, appRoot, reactNativeRoot, undefined, {
+      installTemplate: false,
+    });
+    // The SPM sync re-points the xcframework symlinks and installs the template
+    // itself afterwards, so this in-codegen install must be suppressed.
+    expect(fs.existsSync(codegenPkgSwift)).toBe(false);
+  });
+});

packages/react-native/scripts/spm/spm-utils.js

@@ -330,6 +330,7 @@ function runCodegenAndInstallTemplate(
   appRoot /*: string */,
   reactNativeRoot /*: string */,
   logger /*: {log: (msg: string) => void} */ = {log() {}},
+  opts /*: {installTemplate?: boolean} */ = {},
 ) /*: void */ {
   const codegenScript = path.join(
     reactNativeRoot,
@@ -345,7 +346,13 @@ function runCodegenAndInstallTemplate(
     `node "${codegenScript}" -p "${projectRoot}" -t ios` +
     (projectRoot !== appRoot ? ` -o "${appRoot}"` : '');
   execSync(codegenArgs, {stdio: 'inherit', cwd: projectRoot});
-  installSpmCodegenTemplate(appRoot, reactNativeRoot, logger);
+  // Callers that re-point the xcframework symlinks after codegen (e.g. the SPM
+  // sync, which runs generate-spm-package afterwards) install the template
+  // themselves once the symlinks are final; they pass installTemplate: false to
+  // avoid a wasted write that renderCodegenTemplate would immediately supersede.
+  if (opts.installTemplate !== false) {
+    installSpmCodegenTemplate(appRoot, reactNativeRoot, logger);
+  }
 }
 
 module.exports = {

packages/react-native/scripts/spm/sync-spm-autolinking.js

@@ -18,12 +18,17 @@
  * Usage (called from the Xcode build phase shell script):
  *   node sync-spm-autolinking.js --app-root <path> --react-native-root <path>
  *
+ * The autolinking config (autolinking.json) is generated by the caller
+ * (setup-apple-spm.js) BEFORE this script runs, so codegen below can reuse it
+ * (findCodegenEnabledLibraries short-circuits on a present autolinking.json)
+ * and the slow `@react-native-community/cli config` runs exactly once per sync.
+ *
  * This script:
- *   0. Runs react-native codegen → build/generated/ios/
+ *   0. Runs react-native codegen → build/generated/ios/ (reuses autolinking.json)
  *   1. Ensures xcframework artifacts are downloaded (auto-heals fresh clones)
  *   2. Calls generate-spm-autolinking.js → build/generated/autolinking/Package.swift
  *   3. Calls generate-spm-package.js → build/xcframeworks/Package.swift + symlinks
- *   4. Resolves the VFS overlay template → build/xcframeworks/React-VFS.yaml
+ *   4. Installs the codegen template + resolves the VFS overlay template
  *   5. Writes build/generated/autolinking/.spm-sync-stamp
  */
 
@@ -32,9 +37,6 @@ const {
   resolveCacheSlotVersion,
 } = require('./download-spm-artifacts');
 const {main: generateAutolinking} = require('./generate-spm-autolinking');
-const {
-  generateAutolinkingConfig,
-} = require('./generate-spm-autolinking-config');
 const {main: generatePackage} = require('./generate-spm-package');
 const {
   defaultCacheDir,
@@ -72,21 +74,25 @@ async function main(argv /*:: ?: Array<string> */) /*: Promise<void> */ {
   const reactNativeRoot = path.resolve(parsed['react-native-root']);
   const projectRoot = findProjectRoot(appRoot);
 
+  // The caller (setup-apple-spm.js) already generated autolinking.json before
+  // invoking this script, so codegen reuses it here. Defer the codegen template
+  // install until after generate-spm-package re-points the xcframework symlinks
+  // (see installSpmCodegenTemplate call below) — installing it now would write a
+  // template that the post-symlink install immediately supersedes.
   try {
-    runCodegenAndInstallTemplate(projectRoot, appRoot, reactNativeRoot, {log});
+    runCodegenAndInstallTemplate(
+      projectRoot,
+      appRoot,
+      reactNativeRoot,
+      {log},
+      {
+        installTemplate: false,
+      },
+    );
   } catch {
     log('Codegen failed — continuing with existing output');
   }
 
-  try {
-    const {outputPath} = generateAutolinkingConfig({projectRoot});
-    log(`Refreshed ${path.relative(appRoot, outputPath)}`);
-  } catch (e) {
-    log(
-      `Autolinking config refresh failed: ${e.message}. Using existing autolinking.json if present.`,
-    );
-  }
-
   const pkg = readPackageJson(reactNativeRoot);
   const rawVersion = pkg?.version ?? '0.0.0';
   const flavor = 'debug';