Fix access to observers outside lock in ImageResponseObserverCoordinator (#52346)

javache · facebook-github-bot · commit 69e4252ccba4 · 2025-06-30T13:22:36.000-07:00
Summary: Pull Request resolved: #52346 This is bypassing the mutex, and potentially not thread-safe. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D77541041 fbshipit-source-id: f97415d066786864806836768dbce2d5e68487ef
diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.cpp b/packages/react-native/ReactCommon/react/renderer/imagemanager/ImageResponseObserverCoordinator.cpp
@@ -95,7 +95,7 @@ void ImageResponseObserverCoordinator::nativeImageResponseComplete(
   auto observers = observers_;
   mutex_.unlock();
 
-  for (auto observer : observers_) {
+  for (auto observer : observers) {
     observer->didReceiveImage(imageResponse);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ void ImageResponseObserverCoordinator::nativeImageResponseComplete(`
`95`	`95`	`auto observers = observers_;`
`96`	`96`	`mutex_.unlock();`
`97`	`97`
`98`		`- for (auto observer : observers_) {`
	`98`	`+ for (auto observer : observers) {`
`99`	`99`	`observer->didReceiveImage(imageResponse);`
`100`	`100`	`}`
`101`	`101`	`}`