Skip to content

Commit 6a68b66

Browse files
Faraz Nomanimeta-codesync[bot]
authored andcommitted
Revert D86171725: Call setLayerTreeId from FrameTiming
Differential Revision: D86171725 Original commit changeset: 9425748f463d Original Phabricator Diff: D86171725 fbshipit-source-id: 959cdf929822bd8a378f7382cc901f2e6392dfbc
1 parent f383241 commit 6a68b66

3 files changed

Lines changed: 0 additions & 18 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/FrameTiming.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ internal class FrameTiming(private val window: Window) {
2121

2222
private var frameCounter: Int = 0
2323

24-
private external fun setLayerTreeId(frame: String, layerTreeId: Int)
25-
2624
private val frameMetricsListener =
2725
Window.OnFrameMetricsAvailableListener { _, frameMetrics, dropCount ->
2826
val metrics = FrameMetrics(frameMetrics)
@@ -51,10 +49,6 @@ internal class FrameTiming(private val window: Window) {
5149
return
5250
}
5351
window.addOnFrameMetricsAvailableListener(frameMetricsListener, handler)
54-
55-
// Hardcoded frame identfier and layerTreeId. Needed for DevTools to
56-
// begin parsing frame events.
57-
setLayerTreeId("", 1)
5852
}
5953

6054
internal fun stopMonitoring() {

packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JFrameTiming.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,9 @@ void JFrameTiming::reportFrameTiming(
2727
performanceTracer.reportFrameTiming(frameNumber, startTime, endTime);
2828
}
2929

30-
void JFrameTiming::setLayerTreeId(
31-
jni::alias_ref<jclass> /*unused*/,
32-
jni::alias_ref<jstring> frame,
33-
jint layerTreeId) {
34-
auto& performanceTracer = tracing::PerformanceTracer::getInstance();
35-
36-
performanceTracer.setLayerTreeId(frame->toStdString(), layerTreeId);
37-
}
38-
3930
void JFrameTiming::registerNatives() {
4031
javaClassLocal()->registerNatives({
4132
makeNativeMethod("reportFrameTiming", JFrameTiming::reportFrameTiming),
42-
makeNativeMethod("setLayerTreeId", JFrameTiming::setLayerTreeId),
4333
});
4434
}
4535

packages/react-native/ReactAndroid/src/main/jni/react/devsupport/JFrameTiming.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ class JFrameTiming : public jni::JavaClass<JFrameTiming> {
2121
static void
2222
reportFrameTiming(jni::alias_ref<jclass> /*unused*/, jint frame, jlong paintStartNanos, jlong paintEndNanos);
2323

24-
static void setLayerTreeId(jni::alias_ref<jclass> /*unused*/, jni::alias_ref<jstring> frame, jint layerTreeId);
25-
2624
static void registerNatives();
2725

2826
private:

0 commit comments

Comments
 (0)