Skip to content

Commit 6d19a27

Browse files
javachemeta-codesync[bot]
authored andcommitted
Rename TurboModuleManager to ReactCxxTurboModuleProvider (#55924)
Summary: Pull Request resolved: #55924 Rename the class and files from TurboModuleManager to ReactCxxTurboModuleProvider to better reflect its role and avoid name collision with the Android/iOS TurboModuleManager classes. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D95255535 fbshipit-source-id: 115957096c151b149b792d8e71bd260afa5ce40e
1 parent 417725c commit 6d19a27

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/react-native/ReactCxxPlatform/react/runtime/TurboModuleManager.cpp renamed to packages/react-native/ReactCxxPlatform/react/runtime/ReactCxxTurboModuleProvider.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
#include "TurboModuleManager.h"
8+
#include "ReactCxxTurboModuleProvider.h"
99

1010
#include <react/coremodules/AppStateModule.h>
1111
#include <react/coremodules/DeviceInfoModule.h>
@@ -27,7 +27,7 @@
2727

2828
using namespace facebook::react;
2929

30-
TurboModuleManager::TurboModuleManager(
30+
ReactCxxTurboModuleProvider::ReactCxxTurboModuleProvider(
3131
TurboModuleProviders turboModuleProviders,
3232
std::shared_ptr<CallInvoker> jsInvoker,
3333
JsErrorHandler::OnJsError onJsError,
@@ -50,7 +50,7 @@ TurboModuleManager::TurboModuleManager(
5050
webSocketClientFactory_(std::move(webSocketClientFactory)),
5151
liveReloadCallback_(std::move(liveReloadCallback)) {}
5252

53-
std::shared_ptr<TurboModule> TurboModuleManager::operator()(
53+
std::shared_ptr<TurboModule> ReactCxxTurboModuleProvider::operator()(
5454
const std::string& name) const {
5555
react_native_assert(!name.empty() && "TurboModule name must not be empty");
5656

packages/react-native/ReactCxxPlatform/react/runtime/TurboModuleManager.h renamed to packages/react-native/ReactCxxPlatform/react/runtime/ReactCxxTurboModuleProvider.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ class NativeAnimatedNodesManagerProvider;
2121
class SurfaceDelegate;
2222
struct IDevUIDelegate;
2323

24-
class TurboModuleManager final {
24+
class ReactCxxTurboModuleProvider final {
2525
public:
26-
TurboModuleManager(
26+
ReactCxxTurboModuleProvider(
2727
TurboModuleProviders turboModuleProviders,
2828
std::shared_ptr<CallInvoker> jsInvoker,
2929
JsErrorHandler::OnJsError onJsError,

packages/react-native/ReactCxxPlatform/react/runtime/ReactHost.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include <react/runtime/hermes/HermesInstance.h>
3636
#include <react/threading/MessageQueueThreadImpl.h>
3737

38-
#include "TurboModuleManager.h"
38+
#include "ReactCxxTurboModuleProvider.h"
3939

4040
namespace facebook::react {
4141

@@ -251,7 +251,7 @@ void ReactHost::createReactInstance() {
251251
}
252252

253253
auto liveReloadCallback = [this]() { reloadReactInstance(); };
254-
TurboModuleManager turboModuleManager(
254+
ReactCxxTurboModuleProvider turboModuleManager(
255255
reactInstanceData_->turboModuleProviders,
256256
jsInvoker,
257257
reactInstanceData_->onJsError,

0 commit comments

Comments
 (0)