Skip to content

Commit 70d5c97

Browse files
Nick Lefeverfacebook-github-bot
authored andcommitted
Make Text shadow nodes uncullable on Android (#53376)
Summary: Pull Request resolved: #53376 When encountering embedded <Text> components, with the parent <Text> component setting event handlers, culling away the child <Text> components will break the assignment of the event handlers to the text spans on Android. This diff disables view culling on <Text> components so that event handlers would be correctly assigned to the text fragments once rendered. Changelog: [Internal] Reviewed By: andrewdacenko Differential Revision: D80631997 fbshipit-source-id: f835a249fef1b448b884999ccd75ee06041eca70
1 parent 0ef21bf commit 70d5c97

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • packages/react-native/ReactCommon/react/renderer/components/text

packages/react-native/ReactCommon/react/renderer/components/text/TextShadowNode.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ class TextShadowNode : public ConcreteShadowNode<
3131
auto traits = ConcreteShadowNode::BaseTraits();
3232
#ifdef ANDROID
3333
traits.set(ShadowNodeTraits::Trait::FormsView);
34+
traits.set(ShadowNodeTraits::Trait::Unstable_uncullableView);
3435
#endif
3536
return traits;
3637
}

0 commit comments

Comments
 (0)