Skip to content

Commit 7112c5f

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Split build_js_types from lint action (#55426)
Summary: Pull Request resolved: #55426 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92417806 fbshipit-source-id: d7729d9589944579bf9cb1b592183f3e38a4c0c8
1 parent ce06581 commit 7112c5f

2 files changed

Lines changed: 21 additions & 8 deletions

File tree

.github/actions/lint/action.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,3 @@ runs:
3535
- name: Lint markdown
3636
shell: bash
3737
run: yarn run lint-markdown
38-
- name: Build types
39-
shell: bash
40-
run: yarn build-types --skip-snapshot
41-
- name: Run typescript check of generated types
42-
shell: bash
43-
run: yarn test-generated-typescript

.github/workflows/test-all.yml

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,20 +512,39 @@ jobs:
512512
- name: Run all the linters
513513
uses: ./.github/actions/lint
514514

515+
build_js_types:
516+
runs-on: ubuntu-latest
517+
needs: lint
518+
steps:
519+
- name: Checkout
520+
uses: actions/checkout@v6
521+
- name: Setup Node.js
522+
uses: ./.github/actions/setup-node
523+
- name: Install dependencies
524+
uses: ./.github/actions/yarn-install
525+
- name: Build react-native package types
526+
shell: bash
527+
run: yarn build-types --skip-snapshot
528+
- name: Validate generated types
529+
shell: bash
530+
run: yarn test-generated-typescript
531+
515532
build_debugger_shell:
516533
runs-on: ubuntu-latest
517534
needs: check_code_changes
518535
if: needs.check_code_changes.outputs.debugger_shell == 'true'
519536
steps:
520537
- name: Checkout
521538
uses: actions/checkout@v6
522-
- name: Setup node.js
539+
- name: Setup Node.js
523540
uses: ./.github/actions/setup-node
524-
- name: Run yarn install
541+
- name: Install dependencies
525542
uses: ./.github/actions/yarn-install
526543
- name: Build packages
544+
shell: bash
527545
run: yarn build
528546
- name: Verify debugger-shell build
547+
shell: bash
529548
run: node scripts/debugger-shell/build-binary.js
530549

531550
# This job should help with the E2E flakyness.

0 commit comments

Comments
 (0)