Skip to content

Commit 7e75234

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Collapse lint action into test-all workflow (#55427)
Summary: Pull Request resolved: #55427 Following previous diffs, this now promotes the `lint` action to direct job steps. **Motivation** This has the advantage of making sub-steps in the GitHub UI visible, rather than running the 7 lint steps under a single banner. I feel this is justified in the case of `lint`, although increasing the size of `.github/workflowsl/test-all.yml` slightly, because: - Each step in this job is a distinct tool run with differing output, rather than one logical "action" — and this grouped output is therefore useful to the user. - Lint failures are reasonably frequent for users, emphasising the above. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92417807 fbshipit-source-id: ed24cfa2e581a528e80faec4128d280926f56613
1 parent 7112c5f commit 7e75234

2 files changed

Lines changed: 23 additions & 41 deletions

File tree

.github/actions/lint/action.yml

Lines changed: 0 additions & 37 deletions
This file was deleted.

.github/workflows/test-all.yml

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -504,13 +504,32 @@ jobs:
504504
lint:
505505
runs-on: ubuntu-latest
506506
if: github.repository == 'facebook/react-native'
507-
env:
508-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
509507
steps:
510508
- name: Checkout
511509
uses: actions/checkout@v6
512-
- name: Run all the linters
513-
uses: ./.github/actions/lint
510+
- name: Install dependencies
511+
uses: ./.github/actions/yarn-install
512+
- name: Lint file structure
513+
shell: bash
514+
run: ./.github/workflow-scripts/lint_files.sh
515+
- name: Run shellcheck
516+
shell: bash
517+
run: ./.github/workflow-scripts/analyze_scripts.sh
518+
- name: Prettier
519+
shell: bash
520+
run: yarn run format-check
521+
- name: markdownlint
522+
shell: bash
523+
run: yarn run lint-markdown
524+
- name: ESLint
525+
shell: bash
526+
run: ./.github/workflow-scripts/exec_swallow_error.sh yarn lint --format junit -o ./reports/junit/eslint/results.xml
527+
- name: Flow
528+
shell: bash
529+
run: yarn flow-check
530+
- name: TypeScript
531+
shell: bash
532+
run: yarn test-typescript
514533

515534
build_js_types:
516535
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)