Resubmit: Ensure that ShadowNode measure functions respect constraints (#51299)

Summary:
Pull Request resolved: #51299

## Resubmit

This change was backed out, due to the WinUI Fabric TextLayoutManager not respecting minimum size constraints, causing early debug assert. D74494087 was confirmed to fix this.

For more safety, we limit fatal debug assertsions to `ParagraphShadowNode`, and only log a native error for other ShadowNodes.

## Original

Android's TextLayoutManager may return widths greather than the max measure constraint.

Yoga will clamp these, but this sort of issue points to a logic bug, and creates issues when we are looking at caching text measurements based on constraint reuse.

Let's debug assert that we don't do that, and fix a case of rounding up at a pixel boundary, to ensure that it doesn't go above max width. This should theoretically be safe, since Yoga is already doing this clamping, which is what dictates final size of the TextView.

Changelog: [Internal]

Reviewed By: joevilches

Differential Revision: D74674460

fbshipit-source-id: 807d6629bb799a3b1a55e378a3243065055ce219

Author: NickGerleman

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphShadowNode.cpp

@@ -17,12 +17,23 @@
 #include <react/renderer/graphics/rounding.h>
 #include <react/renderer/telemetry/TransactionTelemetry.h>
 #include <react/renderer/textlayoutmanager/TextLayoutContext.h>
-#include <react/renderer/textlayoutmanager/TextLayoutManagerExtended.h>
+#include <react/utils/FloatComparison.h>
 
 #include <react/renderer/components/text/ParagraphState.h>
 
-namespace facebook::react {
+#define assert_valid_size(size, layoutConstraints)                         \
+  react_native_assert(                                                     \
+      !ReactNativeFeatureFlags::avoidCeilingAvailableAndroidTextWidth() || \
+      ((size).width + kDefaultEpsilon >=                                   \
+           (layoutConstraints).minimumSize.width &&                        \
+       (size).width - kDefaultEpsilon <=                                   \
+           (layoutConstraints).maximumSize.width &&                        \
+       (size).height + kDefaultEpsilon >=                                  \
+           (layoutConstraints).minimumSize.height &&                       \
+       (size).height - kDefaultEpsilon <=                                  \
+           (layoutConstraints).maximumSize.height))
 
+namespace facebook::react {
 using Content = ParagraphShadowNode::Content;
 
 const char ParagraphComponentName[] = "Paragraph";
@@ -212,17 +223,20 @@ Size ParagraphShadowNode::measureContent(
           // PreparedLayout is not trivially copyable on all platforms
           // NOLINTNEXTLINE(performance-move-const-arg)
           std::move(preparedLayout)});
+      assert_valid_size(mesaurements.size, layoutConstraints);
       return mesaurements.size;
     }
   }
 
-  return textLayoutManager_
-      ->measure(
-          AttributedStringBox{attributedString},
-          content.paragraphAttributes,
-          textLayoutContext,
-          layoutConstraints)
-      .size;
+  auto size = textLayoutManager_
+                  ->measure(
+                      AttributedStringBox{attributedString},
+                      content.paragraphAttributes,
+                      textLayoutContext,
+                      layoutConstraints)
+                  .size;
+  assert_valid_size(size, layoutConstraints);
+  return size;
 }
 
 Float ParagraphShadowNode::baseline(

packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp

@@ -15,9 +15,11 @@
 #include <react/renderer/components/view/ViewProps.h>
 #include <react/renderer/components/view/ViewShadowNode.h>
 #include <react/renderer/components/view/conversions.h>
+#include <react/renderer/core/ComponentDescriptor.h>
 #include <react/renderer/core/LayoutConstraints.h>
 #include <react/renderer/core/LayoutContext.h>
 #include <react/renderer/debug/DebugStringConvertibleItem.h>
+#include <react/utils/FloatComparison.h>
 #include <yoga/Yoga.h>
 #include <algorithm>
 #include <limits>
@@ -837,6 +839,21 @@ YGSize YogaLayoutableShadowNode::yogaNodeMeasureCallbackConnector(
   auto size = shadowNode.measureContent(
       threadLocalLayoutContext, {minimumSize, maximumSize});
 
+#ifdef REACT_NATIVE_DEBUG
+  bool widthInBounds = size.width + kDefaultEpsilon >= minimumSize.width &&
+      size.width - kDefaultEpsilon <= maximumSize.width;
+  bool heightInBounds = size.height + kDefaultEpsilon >= minimumSize.height &&
+      size.height - kDefaultEpsilon <= maximumSize.height;
+
+  if (!widthInBounds || !heightInBounds) {
+    LOG(ERROR) << shadowNode.getComponentDescriptor().getComponentName()
+               << " returned an invalid measurement. Min: ["
+               << minimumSize.width << "," << minimumSize.height << "] Max: ["
+               << maximumSize.width << "," << maximumSize.height
+               << "] Actual: [" << size.width << "," << size.height << "]";
+  }
+#endif
+
   return YGSize{
       yogaFloatFromFloat(size.width), yogaFloatFromFloat(size.height)};
 }

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/react/renderer/textlayoutmanager/TextLayoutManager.cpp

@@ -17,15 +17,18 @@ TextMeasurement TextLayoutManager::measure(
     const AttributedStringBox& attributedStringBox,
     const ParagraphAttributes& /*paragraphAttributes*/,
     const TextLayoutContext& /*layoutContext*/,
-    const LayoutConstraints& /*layoutConstraints*/) const {
+    const LayoutConstraints& layoutConstraints) const {
   TextMeasurement::Attachments attachments;
   for (const auto& fragment : attributedStringBox.getValue().getFragments()) {
     if (fragment.isAttachment()) {
       attachments.push_back(
           TextMeasurement::Attachment{{{0, 0}, {0, 0}}, false});
     }
   }
-  return TextMeasurement{{0, 0}, attachments};
+  return TextMeasurement{
+      {layoutConstraints.minimumSize.width,
+       layoutConstraints.minimumSize.height},
+      attachments};
 }
 
 } // namespace facebook::react

packages/react-native/ReactCommon/react/utils/FloatComparison.h

@@ -9,7 +9,9 @@
 
 namespace facebook::react {
 
-inline bool floatEquality(float a, float b, float epsilon = 0.005f) {
+constexpr float kDefaultEpsilon = 0.005f;
+
+inline bool floatEquality(float a, float b, float epsilon = kDefaultEpsilon) {
   return (std::isnan(a) && std::isnan(b)) ||
       (!std::isnan(a) && !std::isnan(b) && fabs(a - b) < epsilon);
 }