Skip to content

Commit 8250db6

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Remove prefersFuseboxFrontend from event reporter (#55549)
Summary: Pull Request resolved: #55549 **Context** Clean up the legacy `rn_inspector.html` entry point. React Native DevTools has been the default since 0.76, and we have now removed all internal dependencies at Meta. **This diff** - Remove `prefersFuseboxFrontend` metadata from `unstable_eventReporter` API. Changelog: [Internal] Reviewed By: vzaidman Differential Revision: D93247602 fbshipit-source-id: 278f847433259c98deb121562e34a12ff59058a2
1 parent 755895e commit 8250db6

5 files changed

Lines changed: 0 additions & 38 deletions

File tree

packages/dev-middleware/src/inspector-proxy/Device.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -457,9 +457,6 @@ export default class Device {
457457
this.#deviceEventReporter?.logRequest(debuggerRequest, 'debugger', {
458458
pageId: debuggerInfo.pageId,
459459
frontendUserAgent: userAgent,
460-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(
461-
debuggerInfo.pageId,
462-
),
463460
});
464461
let processedReq = debuggerRequest;
465462

@@ -680,7 +677,6 @@ export default class Device {
680677
this.#deviceEventReporter?.logResponse(parsedPayload, 'device', {
681678
pageId,
682679
frontendUserAgent: debuggerConnection.userAgent ?? null,
683-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
684680
});
685681
}
686682

@@ -760,7 +756,6 @@ export default class Device {
760756
this.#deviceEventReporter?.logRequest(message, 'proxy', {
761757
pageId,
762758
frontendUserAgent: reloadablePageDebugger.userAgent ?? null,
763-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
764759
});
765760
this.#sendMessageToDevice({
766761
event: 'wrappedEvent',
@@ -911,9 +906,6 @@ export default class Device {
911906
this.#deviceEventReporter?.logRequest(resumeMessage, 'proxy', {
912907
pageId: debuggerInfo.pageId,
913908
frontendUserAgent: debuggerInfo.userAgent ?? null,
914-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(
915-
debuggerInfo.pageId,
916-
),
917909
});
918910
this.#sendMessageToDevice({
919911
event: 'wrappedEvent',
@@ -984,7 +976,6 @@ export default class Device {
984976
this.#deviceEventReporter?.logResponse(response, 'proxy', {
985977
pageId,
986978
frontendUserAgent: debuggerInfo.userAgent ?? null,
987-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
988979
});
989980
return null;
990981
default:
@@ -1064,7 +1055,6 @@ export default class Device {
10641055
this.#deviceEventReporter?.logResponse(response, 'proxy', {
10651056
pageId,
10661057
frontendUserAgent: debuggerInfo.userAgent ?? null,
1067-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
10681058
});
10691059
};
10701060
const sendErrorResponse = (error: string) => {
@@ -1079,7 +1069,6 @@ export default class Device {
10791069
this.#deviceEventReporter?.logResponse(response, 'proxy', {
10801070
pageId,
10811071
frontendUserAgent: debuggerInfo.userAgent ?? null,
1082-
prefersFuseboxFrontend: this.#isPageFuseboxFrontend(pageId),
10831072
});
10841073
};
10851074

@@ -1169,15 +1158,6 @@ export default class Device {
11691158
}
11701159
}
11711160

1172-
#isPageFuseboxFrontend(pageId: ?string): boolean | null {
1173-
const page = pageId == null ? null : this.#pages.get(pageId);
1174-
if (page == null) {
1175-
return null;
1176-
}
1177-
1178-
return this.#pageHasCapability(page, 'prefersFuseboxFrontend');
1179-
}
1180-
11811161
dangerouslyGetSocket(): WS {
11821162
return this.#deviceSocket;
11831163
}

packages/dev-middleware/src/inspector-proxy/DeviceEventReporter.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,11 @@ type DeviceMetadata = Readonly<{
3030
type RequestMetadata = Readonly<{
3131
pageId: string | null,
3232
frontendUserAgent: string | null,
33-
prefersFuseboxFrontend: boolean | null,
3433
}>;
3534

3635
type ResponseMetadata = Readonly<{
3736
pageId: string | null,
3837
frontendUserAgent: string | null,
39-
prefersFuseboxFrontend: boolean | null,
4038
}>;
4139

4240
class DeviceEventReporter {
@@ -101,7 +99,6 @@ class DeviceEventReporter {
10199
deviceName: this.#metadata.deviceName,
102100
pageId: metadata.pageId,
103101
frontendUserAgent: metadata.frontendUserAgent,
104-
prefersFuseboxFrontend: metadata.prefersFuseboxFrontend,
105102
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
106103
});
107104
return;
@@ -128,7 +125,6 @@ class DeviceEventReporter {
128125
deviceName: this.#metadata.deviceName,
129126
pageId: pendingCommand.metadata.pageId,
130127
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
131-
prefersFuseboxFrontend: metadata.prefersFuseboxFrontend,
132128
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
133129
});
134130
return;
@@ -146,7 +142,6 @@ class DeviceEventReporter {
146142
deviceName: this.#metadata.deviceName,
147143
pageId: pendingCommand.metadata.pageId,
148144
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
149-
prefersFuseboxFrontend: metadata.prefersFuseboxFrontend,
150145
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
151146
});
152147
}
@@ -204,7 +199,6 @@ class DeviceEventReporter {
204199
deviceName: this.#metadata.deviceName,
205200
pageId: pendingCommand.metadata.pageId,
206201
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
207-
prefersFuseboxFrontend: pendingCommand.metadata.prefersFuseboxFrontend,
208202
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
209203
});
210204
}
@@ -246,7 +240,6 @@ class DeviceEventReporter {
246240
deviceName: this.#metadata.deviceName,
247241
pageId: pendingCommand.metadata.pageId,
248242
frontendUserAgent: pendingCommand.metadata.frontendUserAgent,
249-
prefersFuseboxFrontend: pendingCommand.metadata.prefersFuseboxFrontend,
250243
connectionUptime: this.#deviceConnectedTimestamp - Date.now(),
251244
});
252245
}

packages/dev-middleware/src/inspector-proxy/types.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,6 @@ export type TargetCapabilityFlags = Readonly<{
3131
*/
3232
nativeSourceCodeFetching?: boolean,
3333

34-
/**
35-
* The target supports the modern `rn_fusebox.html` entry point.
36-
*
37-
* In the launch flow, this controls the Chrome DevTools entrypoint that is used.
38-
*/
39-
prefersFuseboxFrontend?: boolean,
40-
4134
/**
4235
* The target supports multiple concurrent debugger connections.
4336
*

packages/dev-middleware/src/middleware/openDebuggerMiddleware.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ export default function openDebuggerMiddleware({
240240
pageId: target.id,
241241
deviceName: target.deviceName,
242242
targetDescription: target.description,
243-
prefersFuseboxFrontend: true,
244243
});
245244
return;
246245
} catch (e) {

packages/dev-middleware/src/types/EventReporter.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ type SuccessResult<Props: {...} | void = {}> = {
1818
type ErrorResult<ErrorT = unknown, Props: {...} | void = {}> = {
1919
status: 'error',
2020
error: ErrorT,
21-
prefersFuseboxFrontend?: ?boolean,
2221
...Props,
2322
};
2423

@@ -46,7 +45,6 @@ export type ReportableEvent =
4645
...
4746
| SuccessResult<{
4847
targetDescription: string,
49-
prefersFuseboxFrontend: boolean,
5048
...DebuggerSessionIDs,
5149
}>
5250
| ErrorResult<unknown>
@@ -72,7 +70,6 @@ export type ReportableEvent =
7270
...DebuggerSessionIDs,
7371
...ConnectionUptime,
7472
frontendUserAgent: string | null,
75-
prefersFuseboxFrontend: boolean | null,
7673
...
7774
| SuccessResult<void>
7875
| CodedErrorResult<

0 commit comments

Comments
 (0)