Skip to content

Commit 869c03e

Browse files
coadoreact-native-bot
authored andcommitted
Fix VirtualizeSectionList generic arguments (#51496)
Summary: Pull Request resolved: #51496 Fixes problem with generics passed to `VirtualizedSectionList` in generated types. The `flow-api-translator` creates a re-declaration for `export default` variables which shadows generics. Changelog: [Internal] Reviewed By: huntie Differential Revision: D75141051 fbshipit-source-id: 260ef066038320eee3ffa93692f77f1eff5c9205
1 parent 24131c6 commit 869c03e

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

packages/virtualized-lists/Lists/VirtualizedSectionList.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ function ItemWithSeparator<ItemT>(
610610
);
611611
}
612612

613-
export default VirtualizedSectionList as component<
613+
const VirtualizedSectionListComponent = VirtualizedSectionList as component<
614614
ItemT,
615615
SectionT: SectionBase<ItemT, DefaultSectionT> = DefaultSectionT,
616616
>(
@@ -622,3 +622,10 @@ export default VirtualizedSectionList as component<
622622
>,
623623
...VirtualizedSectionListProps<ItemT, SectionT>
624624
);
625+
626+
export default VirtualizedSectionListComponent;
627+
628+
export type AnyVirtualizedSectionList = typeof VirtualizedSectionListComponent<
629+
any,
630+
any,
631+
>;

packages/virtualized-lists/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import typeof FillRateHelper from './Lists/FillRateHelper';
1414
import typeof ViewabilityHelper from './Lists/ViewabilityHelper';
1515
import typeof VirtualizedList from './Lists/VirtualizedList';
16-
import typeof VirtualizedSectionList from './Lists/VirtualizedSectionList';
16+
import type {AnyVirtualizedSectionList} from './Lists/VirtualizedSectionList';
1717

1818
import {typeof VirtualizedListContextResetter} from './Lists/VirtualizedListContext';
1919
import {keyExtractor} from './Lists/VirtualizeUtils';
@@ -45,7 +45,7 @@ export default {
4545
get VirtualizedList(): VirtualizedList {
4646
return require('./Lists/VirtualizedList').default;
4747
},
48-
get VirtualizedSectionList(): VirtualizedSectionList<any, any> {
48+
get VirtualizedSectionList(): AnyVirtualizedSectionList {
4949
return require('./Lists/VirtualizedSectionList').default;
5050
},
5151
get VirtualizedListContextResetter(): VirtualizedListContextResetter {

0 commit comments

Comments
 (0)