feat: update NativeCxxModuleExample

Author: paradowstack

packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp

@@ -9,6 +9,7 @@
 #include <react/bridging/ArrayBuffer.h>
 #include <react/debug/react_native_assert.h>
 #include <iomanip>
+#include <numeric>
 #include <ostream>
 #include <sstream>
 #include <thread>
@@ -24,6 +25,20 @@ std::string to_string_with_precision(double value, int precision = 2) {
   return oss.str();
 }
 
+struct IntegerSequence : jsi::MutableBuffer {
+  explicit IntegerSequence(int32_t size) : data_(size) {
+    std::iota(data_.begin(), data_.end(), 1);
+  }
+
+  size_t size() const override {
+    return data_.size();
+  }
+  uint8_t* data() override {
+    return data_.data();
+  }
+  std::vector<uint8_t> data_;
+};
+
 } // namespace
 
 NativeCxxModuleExample::NativeCxxModuleExample(
@@ -62,29 +77,16 @@ jsi::ArrayBuffer NativeCxxModuleExample::getArrayBuffer(
 
 jsi::ArrayBuffer NativeCxxModuleExample::createNativeBuffer(
     jsi::Runtime& rt,
-    int32_t size) {
-  struct VectorBuffer : jsi::MutableBuffer {
-    explicit VectorBuffer(std::initializer_list<uint8_t> init) : data_(init) {}
-
-    size_t size() const override {
-      return data_.size();
-    }
-    uint8_t* data() override {
-      return data_.data();
-    }
-    std::vector<uint8_t> data_;
-  };
-
-  auto buf = std::make_shared<VectorBuffer>(
-      std::initializer_list<uint8_t>{1, 2, 3, 4, 5, 6, 7, 8, 9, 10});
+    int32_t arg) {
+  auto buf = std::make_shared<IntegerSequence>(arg);
   return jsi::ArrayBuffer(rt, std::move(buf));
 }
 
 AsyncPromise<double> NativeCxxModuleExample::processAsyncBuffer(
     jsi::Runtime& rt,
     jsi::ArrayBuffer arg) {
   auto promise = AsyncPromise<double>(rt, jsInvoker_);
-  auto storage = SafeAsyncArrayBuffer::acquire(rt, arg);
+  auto storage = AsyncArrayBuffer::acquire(rt, arg);
   std::thread([promise, storage = std::move(storage)]() mutable {
     auto sum = 0.0;
     auto bytes = storage.data();
@@ -97,11 +99,13 @@ AsyncPromise<double> NativeCxxModuleExample::processAsyncBuffer(
   return promise;
 }
 
-AsyncPromise<SafeAsyncArrayBuffer> NativeCxxModuleExample::getAsyncBuffer(
-    jsi::Runtime& rt) {
-  auto promise = AsyncPromise<SafeAsyncArrayBuffer>(rt, jsInvoker_);
-  std::thread([promise]() mutable {
-    promise.resolve(SafeAsyncArrayBuffer::wrap({10, 20, 30, 40, 50}));
+AsyncPromise<AsyncArrayBuffer> NativeCxxModuleExample::getAsyncBuffer(
+    jsi::Runtime& rt,
+    int32_t arg) {
+  auto promise = AsyncPromise<AsyncArrayBuffer>(rt, jsInvoker_);
+  std::thread([promise, arg]() mutable {
+    promise.resolve(
+        AsyncArrayBuffer::wrap(std::make_shared<IntegerSequence>(arg)));
   }).detach();
   return promise;
 }

packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.h

@@ -124,13 +124,13 @@ class NativeCxxModuleExample : public NativeCxxModuleExampleCxxSpec<NativeCxxMod
 
   std::vector<std::optional<ObjectStruct>> getArray(jsi::Runtime &rt, std::vector<std::optional<ObjectStruct>> arg);
 
-  jsi::ArrayBuffer getArrayBuffer(jsi::Runtime &rt, jsi::ArrayBuffer payload);
+  jsi::ArrayBuffer getArrayBuffer(jsi::Runtime &rt, jsi::ArrayBuffer arg);
 
-  jsi::ArrayBuffer createNativeBuffer(jsi::Runtime& rt, int32_t size);
+  jsi::ArrayBuffer createNativeBuffer(jsi::Runtime& rt, int32_t arg);
 
   AsyncPromise<double> processAsyncBuffer(jsi::Runtime& rt, jsi::ArrayBuffer arg);
 
-  AsyncPromise<SafeAsyncArrayBuffer> getAsyncBuffer(jsi::Runtime& rt);
+  AsyncPromise<AsyncArrayBuffer> getAsyncBuffer(jsi::Runtime& rt, int32_t arg);
 
   bool getBool(jsi::Runtime &rt, bool arg);
 

packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.js

@@ -85,7 +85,7 @@ export interface Spec extends TurboModule {
   +getArrayBuffer: (payload: ArrayBuffer) => ArrayBuffer;
   +createNativeBuffer: (size: number) => ArrayBuffer;
   +processAsyncBuffer: (payload: ArrayBuffer) => Promise<number>;
-  +getAsyncBuffer: () => Promise<ArrayBuffer>;
+  +getAsyncBuffer: (size: number) => Promise<ArrayBuffer>;
   +getBool: (arg: boolean) => boolean;
   +getConstants: () => ConstantsStruct;
   +getCustomEnum: (arg: EnumInt) => EnumInt;

packages/rn-tester/NativeCxxModuleExample/tests/NativeCxxModuleExampleTests.cpp

@@ -45,6 +45,11 @@ TEST_F(NativeCxxModuleExampleTests, GetArrayBufferReturnsCorrectValues) {
   EXPECT_EQ(bytes[2], 3);
 }
 
+TEST_F(NativeCxxModuleExampleTests, CreateNativeBufferReturnsCorrectSize) {
+  jsi::ArrayBuffer buf = module_->createNativeBuffer(*runtime_, 42);
+  EXPECT_EQ(buf.size(*runtime_), 42);
+}
+
 TEST_F(NativeCxxModuleExampleTests, GetBoolReturnsCorrectValues) {
   EXPECT_FALSE(module_->getBool(*runtime_, false));
   EXPECT_TRUE(module_->getBool(*runtime_, true));

packages/rn-tester/js/examples/TurboModule/NativeCxxModuleExampleExample.js

@@ -112,7 +112,7 @@ class NativeCxxModuleExampleExample extends React.Component<{}, State> {
     },
     processAsyncBuffer: async () => {
       const view = new Uint8Array([10, 20, 30, 40, 50]);
-      const nativeBuffer = NativeCxxModuleExample?.createNativeBuffer(4);
+      const nativeBuffer = NativeCxxModuleExample?.createNativeBuffer(10);
 
       const [byteSum, zeroCopyByteSum] = await Promise.all([
         NativeCxxModuleExample?.processAsyncBuffer(view.buffer),
@@ -125,7 +125,7 @@ class NativeCxxModuleExampleExample extends React.Component<{}, State> {
       );
     },
     getAsyncBuffer: () =>
-      NativeCxxModuleExample?.getAsyncBuffer().then(buffer => {
+      NativeCxxModuleExample?.getAsyncBuffer(10).then(buffer => {
         this._setResult('getAsyncBuffer', new Uint8Array(buffer).toString());
       }),
     getBool: () => NativeCxxModuleExample?.getBool(true),