Fix CQS signal readability-implicit-bool-conversion in xplat/js/react-native-github/packages (#53593)

generatedunixname89002005287564 · facebook-github-bot · commit 8d33e1c205b1 · 2025-09-04T04:01:12.000-07:00
Summary: Pull Request resolved: #53593 Reviewed By: rshest Differential Revision: D81573635 fbshipit-source-id: a367572b7d2b3a9422e47fa05d3c001e607ec0e3
diff --git a/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm b/packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.mm
@@ -54,7 +54,7 @@ void RCTAppSetupPrepareApp(UIApplication *application, BOOL turboModuleEnabled)
 NSArray<NSString *> *RCTAppSetupUnstableModulesRequiringMainQueueSetup(id<RCTDependencyProvider> dependencyProvider)
 {
   // For oss, insert core main queue setup modules here
-  return dependencyProvider ? dependencyProvider.unstableModulesRequiringMainQueueSetup : @[];
+  return (dependencyProvider != nullptr) ? dependencyProvider.unstableModulesRequiringMainQueueSetup : @[];
 }
 
 id<RCTTurboModule> RCTAppSetupDefaultModuleFromClass(Class moduleClass, id<RCTDependencyProvider> dependencyProvider)
@@ -65,11 +65,11 @@ void RCTAppSetupPrepareApp(UIApplication *application, BOOL turboModuleEnabled)
         NSArray<NSString *> *classNames = @[];
 
         if (protocol == @protocol(RCTImageURLLoader)) {
-          classNames = dependencyProvider ? dependencyProvider.imageURLLoaderClassNames : @[];
+          classNames = (dependencyProvider != nullptr) ? dependencyProvider.imageURLLoaderClassNames : @[];
         } else if (protocol == @protocol(RCTImageDataDecoder)) {
-          classNames = dependencyProvider ? dependencyProvider.imageDataDecoderClassNames : @[];
+          classNames = (dependencyProvider != nullptr) ? dependencyProvider.imageDataDecoderClassNames : @[];
         } else if (protocol == @protocol(RCTURLRequestHandler)) {
-          classNames = dependencyProvider ? dependencyProvider.URLRequestHandlerClassNames : @[];
+          classNames = (dependencyProvider != nullptr) ? dependencyProvider.URLRequestHandlerClassNames : @[];
         }
 
         NSMutableArray *modules = [NSMutableArray new];
diff --git a/packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm b/packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm
@@ -78,7 +78,7 @@ - (NSURL *_Nullable)bundleURL
 
 - (NSDictionary<NSString *, Class<RCTComponentViewProtocol>> *)thirdPartyFabricComponents
 {
-  return self.dependencyProvider ? self.dependencyProvider.thirdPartyFabricComponents : @{};
+  return (self.dependencyProvider != nullptr) ? self.dependencyProvider.thirdPartyFabricComponents : @{};
 }
 
 - (void)hostDidStart:(RCTHost *)host
@@ -87,13 +87,15 @@ - (void)hostDidStart:(RCTHost *)host
 
 - (NSArray<NSString *> *)unstableModulesRequiringMainQueueSetup
 {
-  return self.dependencyProvider ? RCTAppSetupUnstableModulesRequiringMainQueueSetup(self.dependencyProvider) : @[];
+  return (self.dependencyProvider != nullptr)
+      ? RCTAppSetupUnstableModulesRequiringMainQueueSetup(self.dependencyProvider)
+      : @[];
 }
 
 - (nullable id<RCTModuleProvider>)getModuleProvider:(const char *)name
 {
   NSString *providerName = [NSString stringWithCString:name encoding:NSUTF8StringEncoding];
-  return self.dependencyProvider ? self.dependencyProvider.moduleProviders[providerName] : nullptr;
+  return (self.dependencyProvider != nullptr) ? self.dependencyProvider.moduleProviders[providerName] : nullptr;
 }
 
 - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name
diff --git a/packages/react-native/Libraries/Blob/RCTBlobCollector.mm b/packages/react-native/Libraries/Blob/RCTBlobCollector.mm
@@ -31,7 +31,7 @@
   __weak RCTCxxBridge *cxxBridge = (RCTCxxBridge *)blobManager.bridge;
   [cxxBridge
       dispatchBlock:^{
-        if (!cxxBridge || cxxBridge.runtime == nullptr) {
+        if ((cxxBridge == nullptr) || cxxBridge.runtime == nullptr) {
           return;
         }
         jsi::Runtime &runtime = *(jsi::Runtime *)cxxBridge.runtime;
diff --git a/packages/react-native/Libraries/Image/RCTBundleAssetImageLoader.mm b/packages/react-native/Libraries/Image/RCTBundleAssetImageLoader.mm
@@ -50,8 +50,8 @@ - (nullable RCTImageLoaderCancellationBlock)loadImageForURL:(NSURL *)imageURL
                                           completionHandler:(RCTImageLoaderCompletionBlock)completionHandler
 {
   UIImage *image = RCTImageFromLocalAssetURL(imageURL);
-  if (image) {
-    if (progressHandler) {
+  if (image != nullptr) {
+    if (progressHandler != nullptr) {
       progressHandler(1, 1);
     }
     completionHandler(nil, image);
diff --git a/packages/react-native/Libraries/Image/RCTGIFImageDecoder.mm b/packages/react-native/Libraries/Image/RCTGIFImageDecoder.mm
@@ -27,7 +27,7 @@ - (BOOL)canDecodeImageData:(NSData *)imageData
   char header[7] = {};
   [imageData getBytes:header length:6];
 
-  return !strcmp(header, "GIF87a") || !strcmp(header, "GIF89a");
+  return (strcmp(header, "GIF87a") == 0) || (strcmp(header, "GIF89a") == 0);
 }
 
 - (RCTImageLoaderCancellationBlock)decodeImageData:(NSData *)imageData
@@ -38,7 +38,7 @@ - (RCTImageLoaderCancellationBlock)decodeImageData:(NSData *)imageData
 {
   RCTAnimatedImage *image = [[RCTAnimatedImage alloc] initWithData:imageData scale:scale];
 
-  if (!image) {
+  if (image == nullptr) {
     completionHandler(nil, nil);
     return ^{
     };
diff --git a/packages/react-native/Libraries/Image/RCTImageBlurUtils.mm b/packages/react-native/Libraries/Image/RCTImageBlurUtils.mm
@@ -19,7 +19,7 @@
   }
 
   // convert to ARGB if it isn't
-  if (CGImageGetBitsPerPixel(imageRef) != 32 || !((CGImageGetBitmapInfo(imageRef) & kCGBitmapAlphaInfoMask))) {
+  if (CGImageGetBitsPerPixel(imageRef) != 32 || (((CGImageGetBitmapInfo(imageRef) & kCGBitmapAlphaInfoMask)) == 0u)) {
     UIGraphicsImageRendererFormat *const rendererFormat = [UIGraphicsImageRendererFormat defaultFormat];
     rendererFormat.scale = inputImage.scale;
     UIGraphicsImageRenderer *const renderer = [[UIGraphicsImageRenderer alloc] initWithSize:inputImage.size
@@ -36,11 +36,11 @@
   buffer1.rowBytes = buffer2.rowBytes = CGImageGetBytesPerRow(imageRef);
   size_t bytes = buffer1.rowBytes * buffer1.height;
   buffer1.data = malloc(bytes);
-  if (!buffer1.data) {
+  if (buffer1.data == nullptr) {
     return inputImage;
   }
   buffer2.data = malloc(bytes);
-  if (!buffer2.data) {
+  if (buffer2.data == nullptr) {
     free(buffer1.data);
     return inputImage;
   }
@@ -60,7 +60,7 @@
     return inputImage;
   }
   void *tempBuffer = malloc(tempBufferSize);
-  if (!tempBuffer) {
+  if (tempBuffer == nullptr) {
     free(buffer1.data);
     free(buffer2.data);
     return inputImage;
diff --git a/packages/react-native/Libraries/Image/RCTImageStoreManager.mm b/packages/react-native/Libraries/Image/RCTImageStoreManager.mm
@@ -48,7 +48,7 @@ - (void)removeImageForTag:(NSString *)imageTag withBlock:(void (^)(void))block
 {
   dispatch_async(_methodQueue, ^{
     [self removeImageForTag:imageTag];
-    if (block) {
+    if (block != nullptr) {
       block();
     }
   });
@@ -58,7 +58,7 @@ - (NSString *)_storeImageData:(NSData *)imageData
 {
   RCTAssertThread(_methodQueue, @"Must be called on RCTImageStoreManager thread");
 
-  if (!_store) {
+  if (_store == nullptr) {
     _store = [NSMutableDictionary new];
     _id = 0;
   }
@@ -112,7 +112,7 @@ - (void)storeImage:(UIImage *)image withBlock:(void (^)(NSString *imageTag))bloc
                   : (RCTResponseSenderBlock)errorCallback)
 {
   NSData *imageData = _store[imageTag];
-  if (!imageData) {
+  if (imageData == nullptr) {
     errorCallback(
         @[ RCTJSErrorFromNSError(RCTErrorWithMessage([NSString stringWithFormat:@"Invalid imageTag: %@", imageTag])) ]);
     return;
@@ -132,7 +132,7 @@ - (void)storeImage:(UIImage *)image withBlock:(void (^)(NSString *imageTag))bloc
   // Dispatching to a background thread to perform base64 decoding
   dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
     NSData *imageData = [[NSData alloc] initWithBase64EncodedString:base64String options:0];
-    if (imageData) {
+    if (imageData != nullptr) {
       dispatch_async(self->_methodQueue, ^{
         successCallback(@[ [self _storeImageData:imageData] ]);
       });
@@ -164,14 +164,14 @@ - (id)sendRequest:(NSURLRequest *)request withDelegate:(id<RCTURLRequestDelegate
 
     NSString *imageTag = request.URL.absoluteString;
     NSData *imageData = self->_store[imageTag];
-    if (!imageData) {
+    if (imageData == nullptr) {
       NSError *error = RCTErrorWithMessage([NSString stringWithFormat:@"Invalid imageTag: %@", imageTag]);
       [delegate URLRequest:cancellationBlock didCompleteWithError:error];
       return;
     }
 
     CGImageSourceRef sourceRef = CGImageSourceCreateWithData((__bridge CFDataRef)imageData, NULL);
-    if (!sourceRef) {
+    if (sourceRef == nullptr) {
       NSError *error =
           RCTErrorWithMessage([NSString stringWithFormat:@"Unable to decode data for imageTag: %@", imageTag]);
       [delegate URLRequest:cancellationBlock didCompleteWithError:error];
@@ -197,7 +197,7 @@ - (id)sendRequest:(NSURLRequest *)request withDelegate:(id<RCTURLRequestDelegate
 
 - (void)cancelRequest:(id)requestToken
 {
-  if (requestToken) {
+  if (requestToken != nullptr) {
     ((void (^)(void))requestToken)();
   }
 }
diff --git a/packages/react-native/Libraries/Image/RCTLocalAssetImageLoader.mm b/packages/react-native/Libraries/Image/RCTLocalAssetImageLoader.mm
@@ -50,8 +50,8 @@ - (nullable RCTImageLoaderCancellationBlock)loadImageForURL:(NSURL *)imageURL
                                           completionHandler:(RCTImageLoaderCompletionBlock)completionHandler
 {
   UIImage *image = RCTImageFromLocalAssetURL(imageURL);
-  if (image) {
-    if (progressHandler) {
+  if (image != nullptr) {
+    if (progressHandler != nullptr) {
       progressHandler(1, 1);
     }
     completionHandler(nil, image);
diff --git a/packages/react-native/Libraries/LinkingIOS/RCTLinkingManager.mm b/packages/react-native/Libraries/LinkingIOS/RCTLinkingManager.mm
@@ -155,7 +155,7 @@ - (void)handleOpenURLNotification:(NSNotification *)notification
 RCT_EXPORT_METHOD(getInitialURL : (RCTPromiseResolveBlock)resolve reject : (__unused RCTPromiseRejectBlock)reject)
 {
   NSURL *initialURL = nil;
-  if (self.bridge.launchOptions[UIApplicationLaunchOptionsURLKey]) {
+  if (self.bridge.launchOptions[UIApplicationLaunchOptionsURLKey] != nullptr) {
     initialURL = self.bridge.launchOptions[UIApplicationLaunchOptionsURLKey];
   } else {
     NSDictionary *userActivityDictionary =
diff --git a/packages/react-native/Libraries/NativeAnimation/Drivers/RCTEventAnimation.mm b/packages/react-native/Libraries/NativeAnimation/Drivers/RCTEventAnimation.mm
@@ -13,7 +13,7 @@ @implementation RCTEventAnimation {
 
 - (instancetype)initWithEventPath:(NSArray<NSString *> *)eventPath valueNode:(RCTValueAnimatedNode *)valueNode
 {
-  if ((self = [super init])) {
+  if ((self = [super init]) != nullptr) {
     _eventPath = eventPath;
     _valueNode = valueNode;
   }

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ - (NSURL *_Nullable)bundleURL`
`78`	`78`
`79`	`79`	`- (NSDictionary<NSString , Class<RCTComponentViewProtocol>> )thirdPartyFabricComponents`
`80`	`80`	`{`
`81`		`- return self.dependencyProvider ? self.dependencyProvider.thirdPartyFabricComponents : @{};`
	`81`	`+ return (self.dependencyProvider != nullptr) ? self.dependencyProvider.thirdPartyFabricComponents : @{};`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`- (void)hostDidStart:(RCTHost *)host`
`@@ -87,13 +87,15 @@ - (void)hostDidStart:(RCTHost *)host`
`87`	`87`
`88`	`88`	`- (NSArray<NSString > )unstableModulesRequiringMainQueueSetup`
`89`	`89`	`{`
`90`		`- return self.dependencyProvider ? RCTAppSetupUnstableModulesRequiringMainQueueSetup(self.dependencyProvider) : @[];`
	`90`	`+ return (self.dependencyProvider != nullptr)`
	`91`	`+ ? RCTAppSetupUnstableModulesRequiringMainQueueSetup(self.dependencyProvider)`
	`92`	`+ : @[];`
`91`	`93`	`}`
`92`	`94`
`93`	`95`	`- (nullable id<RCTModuleProvider>)getModuleProvider:(const char *)name`
`94`	`96`	`{`
`95`	`97`	`NSString *providerName = [NSString stringWithCString:name encoding:NSUTF8StringEncoding];`
`96`		`- return self.dependencyProvider ? self.dependencyProvider.moduleProviders[providerName] : nullptr;`
	`98`	`+ return (self.dependencyProvider != nullptr) ? self.dependencyProvider.moduleProviders[providerName] : nullptr;`
`97`	`99`	`}`
`98`	`100`
`99`	`101`	`- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`__weak RCTCxxBridge cxxBridge = (RCTCxxBridge )blobManager.bridge;`
`32`	`32`	`[cxxBridge`
`33`	`33`	`dispatchBlock:^{`
`34`		`- if (!cxxBridge \|\| cxxBridge.runtime == nullptr) {`
	`34`	`+ if ((cxxBridge == nullptr) \|\| cxxBridge.runtime == nullptr) {`
`35`	`35`	`return;`
`36`	`36`	`}`
`37`	`37`	`jsi::Runtime &runtime = (jsi::Runtime )cxxBridge.runtime;`
Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ - (nullable RCTImageLoaderCancellationBlock)loadImageForURL:(NSURL *)imageURL`
`50`	`50`	`completionHandler:(RCTImageLoaderCompletionBlock)completionHandler`
`51`	`51`	`{`
`52`	`52`	`UIImage *image = RCTImageFromLocalAssetURL(imageURL);`
`53`		`- if (image) {`
`54`		`- if (progressHandler) {`
	`53`	`+ if (image != nullptr) {`
	`54`	`+ if (progressHandler != nullptr) {`
`55`	`55`	`progressHandler(1, 1);`
`56`	`56`	`}`
`57`	`57`	`completionHandler(nil, image);`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ - (BOOL)canDecodeImageData:(NSData *)imageData`
`27`	`27`	`char header[7] = {};`
`28`	`28`	`[imageData getBytes:header length:6];`
`29`	`29`
`30`		`- return !strcmp(header, "GIF87a") \|\| !strcmp(header, "GIF89a");`
	`30`	`+ return (strcmp(header, "GIF87a") == 0) \|\| (strcmp(header, "GIF89a") == 0);`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`- (RCTImageLoaderCancellationBlock)decodeImageData:(NSData *)imageData`
`@@ -38,7 +38,7 @@ - (RCTImageLoaderCancellationBlock)decodeImageData:(NSData *)imageData`
`38`	`38`	`{`
`39`	`39`	`RCTAnimatedImage *image = [[RCTAnimatedImage alloc] initWithData:imageData scale:scale];`
`40`	`40`
`41`		`- if (!image) {`
	`41`	`+ if (image == nullptr) {`
`42`	`42`	`completionHandler(nil, nil);`
`43`	`43`	`return ^{`
`44`	`44`	`};`
Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ - (void)handleOpenURLNotification:(NSNotification *)notification`
`155`	`155`	`RCT_EXPORT_METHOD(getInitialURL : (RCTPromiseResolveBlock)resolve reject : (__unused RCTPromiseRejectBlock)reject)`
`156`	`156`	`{`
`157`	`157`	`NSURL *initialURL = nil;`
`158`		`- if (self.bridge.launchOptions[UIApplicationLaunchOptionsURLKey]) {`
	`158`	`+ if (self.bridge.launchOptions[UIApplicationLaunchOptionsURLKey] != nullptr) {`
`159`	`159`	`initialURL = self.bridge.launchOptions[UIApplicationLaunchOptionsURLKey];`
`160`	`160`	`} else {`
`161`	`161`	`NSDictionary *userActivityDictionary =`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ @implementation RCTEventAnimation {`
`13`	`13`
`14`	`14`	`- (instancetype)initWithEventPath:(NSArray<NSString > )eventPath valueNode:(RCTValueAnimatedNode *)valueNode`
`15`	`15`	`{`
`16`		`- if ((self = [super init])) {`
	`16`	`+ if ((self = [super init]) != nullptr) {`
`17`	`17`	`_eventPath = eventPath;`
`18`	`18`	`_valueNode = valueNode;`
`19`	`19`	`}`