Skip to content

Commit 987e3f8

Browse files
huntiefacebook-github-bot
authored andcommitted
Make NetworkingModule handlers internal (#52438)
Summary: Pull Request resolved: #52438 Motivation: After some investigation, these make sense as private APIs, and we intend to modify `UriHandler` slightly in order to report blob response body payloads via CDP for Network debugging. Changelog: [Android][Removed] - Internalize `NetworkingModule`'s `UriHandler`, `RequestBodyHandler`, and `ResponseHandler` APIs Reviewed By: cortinico Differential Revision: D77799144 fbshipit-source-id: 20c36f52a900830091a253ab9917832c30b31d31
1 parent 27723c7 commit 987e3f8

2 files changed

Lines changed: 9 additions & 30 deletions

File tree

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2889,16 +2889,10 @@ public final class com/facebook/react/modules/network/NetworkingModule : com/fac
28892889
public fun <init> (Lcom/facebook/react/bridge/ReactApplicationContext;Ljava/util/List;)V
28902890
public fun abortRequest (D)V
28912891
public fun addListener (Ljava/lang/String;)V
2892-
public final fun addRequestBodyHandler (Lcom/facebook/react/modules/network/NetworkingModule$RequestBodyHandler;)V
2893-
public final fun addResponseHandler (Lcom/facebook/react/modules/network/NetworkingModule$ResponseHandler;)V
2894-
public final fun addUriHandler (Lcom/facebook/react/modules/network/NetworkingModule$UriHandler;)V
28952892
public fun clearCookies (Lcom/facebook/react/bridge/Callback;)V
28962893
public fun initialize ()V
28972894
public fun invalidate ()V
28982895
public fun removeListeners (D)V
2899-
public final fun removeRequestBodyHandler (Lcom/facebook/react/modules/network/NetworkingModule$RequestBodyHandler;)V
2900-
public final fun removeResponseHandler (Lcom/facebook/react/modules/network/NetworkingModule$ResponseHandler;)V
2901-
public final fun removeUriHandler (Lcom/facebook/react/modules/network/NetworkingModule$UriHandler;)V
29022896
public fun sendRequest (Ljava/lang/String;Ljava/lang/String;DLcom/facebook/react/bridge/ReadableArray;Lcom/facebook/react/bridge/ReadableMap;Ljava/lang/String;ZDZ)V
29032897
public final fun sendRequestInternal (Ljava/lang/String;Ljava/lang/String;ILcom/facebook/react/bridge/ReadableArray;Lcom/facebook/react/bridge/ReadableMap;Ljava/lang/String;ZIZ)V
29042898
public static final fun setCustomClientBuilder (Lcom/facebook/react/modules/network/CustomClientBuilder;)V
@@ -2911,21 +2905,6 @@ public final class com/facebook/react/modules/network/NetworkingModule$Companion
29112905
public abstract interface class com/facebook/react/modules/network/NetworkingModule$CustomClientBuilder : com/facebook/react/modules/network/CustomClientBuilder {
29122906
}
29132907

2914-
public abstract interface class com/facebook/react/modules/network/NetworkingModule$RequestBodyHandler {
2915-
public abstract fun supports (Lcom/facebook/react/bridge/ReadableMap;)Z
2916-
public abstract fun toRequestBody (Lcom/facebook/react/bridge/ReadableMap;Ljava/lang/String;)Lokhttp3/RequestBody;
2917-
}
2918-
2919-
public abstract interface class com/facebook/react/modules/network/NetworkingModule$ResponseHandler {
2920-
public abstract fun supports (Ljava/lang/String;)Z
2921-
public abstract fun toResponseData (Lokhttp3/ResponseBody;)Lcom/facebook/react/bridge/WritableMap;
2922-
}
2923-
2924-
public abstract interface class com/facebook/react/modules/network/NetworkingModule$UriHandler {
2925-
public abstract fun fetch (Landroid/net/Uri;)Lcom/facebook/react/bridge/WritableMap;
2926-
public abstract fun supports (Landroid/net/Uri;Ljava/lang/String;)Z
2927-
}
2928-
29292908
public abstract interface class com/facebook/react/modules/network/OkHttpClientFactory {
29302909
public abstract fun createNewNetworkModuleClient ()Lokhttp3/OkHttpClient;
29312910
}

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.kt

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class NetworkingModule(
5757
* Allows to implement a custom fetching process for specific URIs. It is the handler's job to
5858
* fetch the URI and return the JS body payload.
5959
*/
60-
public interface UriHandler {
60+
internal interface UriHandler {
6161
/** Returns if the handler should be used for an URI. */
6262
public fun supports(uri: Uri, responseType: String): Boolean
6363

@@ -66,7 +66,7 @@ public class NetworkingModule(
6666
}
6767

6868
/** Allows adding custom handling to build the [RequestBody] from the JS body payload. */
69-
public interface RequestBodyHandler {
69+
internal interface RequestBodyHandler {
7070
/** Returns if the handler should be used for a JS body payload. */
7171
public fun supports(map: ReadableMap): Boolean
7272

@@ -75,7 +75,7 @@ public class NetworkingModule(
7575
}
7676

7777
/** Allows adding custom handling to build the JS body payload from the [ResponseBody]. */
78-
public interface ResponseHandler {
78+
internal interface ResponseHandler {
7979
/** Returns if the handler should be used for a response type. */
8080
public fun supports(responseType: String): Boolean
8181

@@ -180,27 +180,27 @@ public class NetworkingModule(
180180
uriHandlers.clear()
181181
}
182182

183-
public fun addUriHandler(handler: UriHandler): Unit {
183+
internal fun addUriHandler(handler: UriHandler): Unit {
184184
uriHandlers.add(handler)
185185
}
186186

187-
public fun addRequestBodyHandler(handler: RequestBodyHandler): Unit {
187+
internal fun addRequestBodyHandler(handler: RequestBodyHandler): Unit {
188188
requestBodyHandlers.add(handler)
189189
}
190190

191-
public fun addResponseHandler(handler: ResponseHandler): Unit {
191+
internal fun addResponseHandler(handler: ResponseHandler): Unit {
192192
responseHandlers.add(handler)
193193
}
194194

195-
public fun removeUriHandler(handler: UriHandler): Unit {
195+
internal fun removeUriHandler(handler: UriHandler): Unit {
196196
uriHandlers.remove(handler)
197197
}
198198

199-
public fun removeRequestBodyHandler(handler: RequestBodyHandler): Unit {
199+
internal fun removeRequestBodyHandler(handler: RequestBodyHandler): Unit {
200200
requestBodyHandlers.remove(handler)
201201
}
202202

203-
public fun removeResponseHandler(handler: ResponseHandler): Unit {
203+
internal fun removeResponseHandler(handler: ResponseHandler): Unit {
204204
responseHandlers.remove(handler)
205205
}
206206

0 commit comments

Comments
 (0)