Skip to content

Commit 9b90675

Browse files
huntiemeta-codesync[bot]
authored andcommitted
Include manufacturer in deviceName metadata (#55699)
Summary: Pull Request resolved: #55699 Helps with devices that have obscure model names, and aligns with presentation in Android Studio (e.g. Logcat device selection). Changelog: [Android][Changed] - CDP: The`deviceName` field in app metadata is now prefixed with the manufacturer Reviewed By: rubennorte, emily8rown Differential Revision: D94082955 fbshipit-source-id: 4305eaefed0170354480a88501c6b95560421dfd
1 parent aabdf55 commit 9b90675

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoHelpers.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public object AndroidInfoHelpers {
7777
"appDisplayName" to appDisplayName,
7878
"appIdentifier" to appIdentifier,
7979
"platform" to "android",
80-
"deviceName" to Build.MODEL,
80+
"deviceName" to "${Build.MANUFACTURER} ${Build.MODEL}",
8181
"reactNativeVersion" to getReactNativeVersionString(),
8282
)
8383
}

0 commit comments

Comments
 (0)