Commit ad2cf4d
fix: correct Android logical border radius mapping (#57271)
Summary:
Fixes incorrect Android mapping for `borderEndStartRadius` and `borderStartEndRadius`.
Fixes #57202
## Changelog:
[Android][Fixed] - Correct logical border radius mapping for `borderEndStartRadius` and `borderStartEndRadius`.
Pull Request resolved: #57271
Test Plan:
- Reviewed the logical corner mapping implementation in `BorderRadiusStyle.kt`.
- Verified that `borderEndStartRadius` and `borderStartEndRadius` were mapped to opposite corners.
- Swapped the mappings so Android behavior matches iOS and CSS logical corner expectations.
Updated `BorderRadiusStyleTest.kt` priority expectations to match the corrected (CSS-spec-compliant) corner mapping and ran the ReactAndroid unit tests:
buck2 test fbsource//xplat/js/react-native-github/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager:uimanager_BorderRadiusStyleTestAndroid
Before updating the test expectations: Pass 2, Fail 3 (`testCorrectPriorityLTR`, `testCorrectPriorityRTL`, `testCorrectPriorityRTLNoSwap`). After: Pass 5, Fail 0. `arc f`/`arc lint`: no issues.
Reviewed By: jorge-cab, christophpurrer
Differential Revision: D109014253
Pulled By: fabriziocucci
fbshipit-source-id: 247e99700a858d693a10871f13b562a392d7b07b1 parent 57ce6bc commit ad2cf4d
2 files changed
Lines changed: 12 additions & 12 deletions
File tree
- packages/react-native/ReactAndroid/src
- main/java/com/facebook/react/uimanager/style
- test/java/com/facebook/react/uimanager
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | | - | |
| 168 | + | |
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
| 182 | + | |
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
| 203 | + | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
| 91 | + | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
| 139 | + | |
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
| 160 | + | |
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
| |||
0 commit comments