Skip to content

Commit b392035

Browse files
hurali97meta-codesync[bot]
authored andcommitted
fix: add line break to gradle.properties for template testing (#57107)
Summary: This fixes the failing CI jobs on main for `template` testing. The job fails as they echo `react.internal.mavenLocalRepo=...` to the `gradle.properties` of template test project. As a result of which the `gradle.properties` look like below: ```properties android.builtInKotlin=false android.newDsl=falsereact.internal.mavenLocalRepo=... ``` To fix it we add a line break in the `echo` command. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [FIXED] - add line break to gradle.properties for template testing Pull Request resolved: #57107 Test Plan: - CI Passing - Verified Locally Reviewed By: cortinico Differential Revision: D107880136 Pulled By: cipolleschi fbshipit-source-id: 81cf2fe53c1c2285f79db538aa5aa3cb745f796d
1 parent df0d7de commit b392035

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/e2e-android-templateapp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ jobs:
6666
6767
echo "Feed maven local to gradle.properties"
6868
cd /tmp/RNTestProject
69-
echo "react.internal.mavenLocalRepo=$MAVEN_LOCAL" >> android/gradle.properties
69+
echo "\nreact.internal.mavenLocalRepo=$MAVEN_LOCAL" >> android/gradle.properties
7070
7171
# Build
7272
cd android

scripts/release-testing/test-release-local.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ async function testRNTestProject(
292292

293293
// need to do this here so that Android will be properly setup either way
294294
exec(
295-
`echo "react.internal.mavenLocalRepo=${mavenLocalPath}" >> android/gradle.properties`,
295+
`echo "\nreact.internal.mavenLocalRepo=${mavenLocalPath}" >> android/gradle.properties`,
296296
);
297297

298298
// Only build the simulator architecture. CI is however generating only that one.

0 commit comments

Comments
 (0)