Skip to content

Commit be91c26

Browse files
Gori Shanker Sutharmeta-codesync[bot]
authored andcommitted
Fix copy-paste error in DevToolsRuntimeSettings (#55010)
Summary: Fixes a copy-paste error in `DevToolsRuntimeSettings::setReloadAndProfileConfig` where `recordChangeDescriptions` was guarded by the wrong optional field. The correct conditional check is already used in https://github.com/facebook/react-native/blob/main/packages/react-native/React/CoreModules/RCTDevToolsRuntimeSettingsModule.mm#L28 ## Changelog: [INTERNAL] [FIXED] Fix incorrect optional field check in DevToolsRuntimeSettings Pull Request resolved: #55010 Test Plan: Code inspection only – trivial copy-paste fix with no behavior change outside correctly applying `recordChangeDescriptions` when present. Reviewed By: mdvacca Differential Revision: D90011483 Pulled By: cortinico fbshipit-source-id: c00c3340625a11673a7e9011f1e373474d5a37e3
1 parent 89ac112 commit be91c26

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ void DevToolsRuntimeSettings::setReloadAndProfileConfig(
1414
if (config.shouldReloadAndProfile.has_value()) {
1515
_config.shouldReloadAndProfile = config.shouldReloadAndProfile.value();
1616
}
17-
if (config.shouldReloadAndProfile.has_value()) {
17+
if (config.recordChangeDescriptions.has_value()) {
1818
_config.recordChangeDescriptions = config.recordChangeDescriptions.value();
1919
}
2020
};

0 commit comments

Comments
 (0)