Skip to content

Commit ca5f4d1

Browse files
javachefacebook-github-bot
authored andcommitted
Disable enableModuleArgumentNSNullConversionIOS by default (#51576)
Summary: Pull Request resolved: #51576 This is causing some internal test failures for now, so disabling the behaviour to prevent further rollout. Changelog: [iOS][Removed] Disable fix for #51103 until more testing can be done. Differential Revision: D75320842 fbshipit-source-id: 39c115afd11e5b1aca6cdc1fc18ec7e83eb10382
1 parent b6292d2 commit ca5f4d1

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<fcee66a9800d5b3b1105df73d33feea9>>
7+
* @generated SignedSource<<07ea15d4fd3f3bc73c8f49cd24724caf>>
88
*/
99

1010
/**
@@ -71,7 +71,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
7171

7272
override fun enableMainQueueModulesOnIOS(): Boolean = false
7373

74-
override fun enableModuleArgumentNSNullConversionIOS(): Boolean = true
74+
override fun enableModuleArgumentNSNullConversionIOS(): Boolean = false
7575

7676
override fun enableNativeCSSParsing(): Boolean = false
7777

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<c80be05a320b2cb0e78865492f503922>>
7+
* @generated SignedSource<<6692978a1497fa9e99d539511388c9fa>>
88
*/
99

1010
/**
@@ -124,7 +124,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
124124
}
125125

126126
bool enableModuleArgumentNSNullConversionIOS() override {
127-
return true;
127+
return false;
128128
}
129129

130130
bool enableNativeCSSParsing() override {

packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ const definitions: FeatureFlagDefinitions = {
300300
ossReleaseStage: 'none',
301301
},
302302
enableModuleArgumentNSNullConversionIOS: {
303-
defaultValue: true,
303+
defaultValue: false,
304304
metadata: {
305305
description:
306306
'Enable NSNull conversion when handling module arguments on iOS',

packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<cbcc6da9a0d0652dddd99977690a258a>>
7+
* @generated SignedSource<<4d96a5f9132ea827faeb183fe8bbf095>>
88
* @flow strict
99
* @noformat
1010
*/
@@ -281,7 +281,7 @@ export const enableMainQueueModulesOnIOS: Getter<boolean> = createNativeFlagGett
281281
/**
282282
* Enable NSNull conversion when handling module arguments on iOS
283283
*/
284-
export const enableModuleArgumentNSNullConversionIOS: Getter<boolean> = createNativeFlagGetter('enableModuleArgumentNSNullConversionIOS', true);
284+
export const enableModuleArgumentNSNullConversionIOS: Getter<boolean> = createNativeFlagGetter('enableModuleArgumentNSNullConversionIOS', false);
285285
/**
286286
* Parse CSS strings using the Fabric CSS parser instead of ViewConfig processing
287287
*/

0 commit comments

Comments
 (0)