Skip to content

Commit cf52852

Browse files
cortinicofacebook-github-bot
authored andcommitted
Remove dead Inspector.kt/JInspector.h/.cpp code (#53403)
Summary: Pull Request resolved: #53403 This code is Legacy and totally unused. It should be safe to remove it altogether. This class is public but no one is using it in OSS + no one should be using it, so I don't think we'll need the full deprecation cycle for it. Changelog: [Android] [Removed] - Removed unused `Inspector` public class from React Android Reviewed By: cipolleschi Differential Revision: D80711515 fbshipit-source-id: 83134851877fcbccd50f7a5b75b2ab8906b3416a
1 parent 0530ea3 commit cf52852

6 files changed

Lines changed: 0 additions & 298 deletions

File tree

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -744,34 +744,6 @@ public abstract class com/facebook/react/bridge/GuardedRunnable : java/lang/Runn
744744
public abstract fun runGuarded ()V
745745
}
746746

747-
public final class com/facebook/react/bridge/Inspector {
748-
public static final field Companion Lcom/facebook/react/bridge/Inspector$Companion;
749-
public static final fun connect (ILcom/facebook/react/bridge/Inspector$RemoteConnection;)Lcom/facebook/react/bridge/Inspector$LocalConnection;
750-
public static final fun getPages ()Ljava/util/List;
751-
}
752-
753-
public final class com/facebook/react/bridge/Inspector$Companion {
754-
public final fun connect (ILcom/facebook/react/bridge/Inspector$RemoteConnection;)Lcom/facebook/react/bridge/Inspector$LocalConnection;
755-
public final fun getPages ()Ljava/util/List;
756-
}
757-
758-
public final class com/facebook/react/bridge/Inspector$LocalConnection {
759-
public final fun disconnect ()V
760-
public final fun sendMessage (Ljava/lang/String;)V
761-
}
762-
763-
public final class com/facebook/react/bridge/Inspector$Page {
764-
public final fun getId ()I
765-
public final fun getTitle ()Ljava/lang/String;
766-
public final fun getVM ()Ljava/lang/String;
767-
public fun toString ()Ljava/lang/String;
768-
}
769-
770-
public abstract interface class com/facebook/react/bridge/Inspector$RemoteConnection {
771-
public abstract fun onDisconnect ()V
772-
public abstract fun onMessage (Ljava/lang/String;)V
773-
}
774-
775747
public class com/facebook/react/bridge/JSApplicationCausedNativeException : java/lang/RuntimeException {
776748
public fun <init> (Ljava/lang/String;)V
777749
public fun <init> (Ljava/lang/String;Ljava/lang/Throwable;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/Inspector.kt

Lines changed: 0 additions & 78 deletions
This file was deleted.

packages/react-native/ReactAndroid/src/main/jni/react/jni/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ add_library(
5454
CatalystInstanceImpl.cpp
5555
InspectorNetworkRequestListener.cpp
5656
JExecutor.cpp
57-
JInspector.cpp
5857
JMessageQueueThread.cpp
5958
JReactCxxErrorHandler.cpp
6059
JReactSoftExceptionLogger.cpp

packages/react-native/ReactAndroid/src/main/jni/react/jni/JInspector.cpp

Lines changed: 0 additions & 112 deletions
This file was deleted.

packages/react-native/ReactAndroid/src/main/jni/react/jni/JInspector.h

Lines changed: 0 additions & 77 deletions
This file was deleted.

packages/react-native/ReactAndroid/src/main/jni/react/jni/OnLoad.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "CatalystInstanceImpl.h"
1414
#include "CxxModuleWrapperBase.h"
1515
#include "InspectorNetworkRequestListener.h"
16-
#include "JInspector.h"
1716
#include "JavaScriptExecutorHolder.h"
1817
#include "ReactInstanceManagerInspectorTarget.h"
1918

@@ -41,7 +40,6 @@ extern "C" JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
4140
CatalystInstanceImpl::registerNatives();
4241
#endif
4342
CxxModuleWrapperBase::registerNatives();
44-
JInspector::registerNatives();
4543
ReactInstanceManagerInspectorTarget::registerNatives();
4644
InspectorNetworkRequestListener::registerNatives();
4745
});

0 commit comments

Comments
 (0)