Skip to content

Commit ddc65bb

Browse files
javachefacebook-github-bot
authored andcommitted
Drop cxxreact:bridge dep from runtimescheduler
Summary: Narrow the runtimescheduler's cxxreact dep. Previously runtimescheduler depended on the full `cxxreact:bridge` target; it only needs `cxxreact:tracesection` (for `TraceSection.h`) plus `jserrorhandler:jserrorhandler` (for `handleJSError`, since Phase 1 moved `ErrorUtils` there) plus `jsi` directly. Also adds `jsi` to the explicit dep list — `runtimescheduler` was previously pulling it in transitively through `cxxreact:bridge`. Verified with `buck2 uquery 'somepath(...:runtimeschedulerAndroid, ...:bridgeAndroid)'` — no path; the edge is gone. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D108786501
1 parent e18cc59 commit ddc65bb

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

packages/react-native/ReactCommon/react/renderer/runtimescheduler/React-runtimescheduler.podspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ Pod::Spec.new do |s|
4747
s.dependency "React-utils"
4848
s.dependency "React-featureflags"
4949
s.dependency "React-timing"
50+
s.dependency "React-jserrorhandler"
5051
s.dependency "React-jsi"
5152
s.dependency "React-performancetimeline"
5253
s.dependency "React-rendererconsistency"

packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
#include <ReactCommon/RuntimeExecutor.h>
1111
#include <cxxreact/JSBigString.h>
12-
#include <cxxreact/JSExecutor.h>
1312
#include <cxxreact/ReactMarker.h>
1413
#include <cxxreact/TraceSection.h>
1514
#include <glog/logging.h>

0 commit comments

Comments
 (0)