Remove dead RAMBundleRegistry::singleBundleRegistry factory (#57143)

sammy-SC · meta-codesync[bot] · commit e0aa800f0852 · 2026-06-09T06:41:25.000-07:00
Summary: Pull Request resolved: #57143 `RAMBundleRegistry::singleBundleRegistry` was a static factory that wrapped the public `RAMBundleRegistry` constructor, but it had no callers anywhere. Objects are constructed via the public constructor directly. This removes the orphaned factory; the sibling `multipleBundlesRegistry`, the constructor, `MAIN_BUNDLE_ID`, `registerBundle`, `getModule`, and `getBundle` are all left intact. Changelog: [Internal] Differential Revision: D108012903
diff --git a/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.cpp b/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.cpp
@@ -20,11 +20,6 @@ namespace facebook::react {
 constexpr uint32_t RAMBundleRegistry::MAIN_BUNDLE_ID;
 #pragma clang diagnostic pop
 
-std::unique_ptr<RAMBundleRegistry> RAMBundleRegistry::singleBundleRegistry(
-    std::unique_ptr<JSModulesUnbundle> mainBundle) {
-  return std::make_unique<RAMBundleRegistry>(std::move(mainBundle));
-}
-
 std::unique_ptr<RAMBundleRegistry> RAMBundleRegistry::multipleBundlesRegistry(
     std::unique_ptr<JSModulesUnbundle> mainBundle,
     std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory) {
diff --git a/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.h b/packages/react-native/ReactCommon/cxxreact/RAMBundleRegistry.h
@@ -27,7 +27,6 @@ class RN_EXPORT [[deprecated("This API will be removed along with the legacy arc
  public:
   constexpr static uint32_t MAIN_BUNDLE_ID = 0;
 
-  static std::unique_ptr<RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<JSModulesUnbundle> mainBundle);
   static std::unique_ptr<RAMBundleRegistry> multipleBundlesRegistry(
       std::unique_ptr<JSModulesUnbundle> mainBundle,
       std::function<std::unique_ptr<JSModulesUnbundle>(std::string)> factory);
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
@@ -4177,7 +4177,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
   public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
@@ -4174,7 +4174,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
   public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
@@ -6358,7 +6358,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
   public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
@@ -6355,7 +6355,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
   public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
@@ -2758,7 +2758,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
   public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }
diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
@@ -2755,7 +2755,6 @@ class facebook::react::RAMBundleRegistry {
   public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;
   public static constexpr uint32_t MAIN_BUNDLE_ID;
   public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);
-  public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);
   public virtual ~RAMBundleRegistry() = default;
   public void registerBundle(uint32_t bundleId, std::string bundlePath);
 }

Original file line number	Diff line number	Diff line change
`@@ -4177,7 +4177,6 @@ class facebook::react::RAMBundleRegistry {`
`4177`	`4177`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`4178`	`4178`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`4179`	`4179`	`public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`4180`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);`
`4181`	`4180`	`public virtual ~RAMBundleRegistry() = default;`
`4182`	`4181`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`4183`	`4182`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4174,7 +4174,6 @@ class facebook::react::RAMBundleRegistry {`
`4174`	`4174`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`4175`	`4175`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`4176`	`4176`	`public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`4177`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);`
`4178`	`4177`	`public virtual ~RAMBundleRegistry() = default;`
`4179`	`4178`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`4180`	`4179`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6358,7 +6358,6 @@ class facebook::react::RAMBundleRegistry {`
`6358`	`6358`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`6359`	`6359`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`6360`	`6360`	`public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`6361`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);`
`6362`	`6361`	`public virtual ~RAMBundleRegistry() = default;`
`6363`	`6362`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`6364`	`6363`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6355,7 +6355,6 @@ class facebook::react::RAMBundleRegistry {`
`6355`	`6355`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`6356`	`6356`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`6357`	`6357`	`public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`6358`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);`
`6359`	`6358`	`public virtual ~RAMBundleRegistry() = default;`
`6360`	`6359`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`6361`	`6360`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2758,7 +2758,6 @@ class facebook::react::RAMBundleRegistry {`
`2758`	`2758`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`2759`	`2759`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`2760`	`2760`	`public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`2761`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);`
`2762`	`2761`	`public virtual ~RAMBundleRegistry() = default;`
`2763`	`2762`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`2764`	`2763`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2755,7 +2755,6 @@ class facebook::react::RAMBundleRegistry {`
`2755`	`2755`	`public facebook::react::RAMBundleRegistry& operator=(facebook::react::RAMBundleRegistry&&) = default;`
`2756`	`2756`	`public static constexpr uint32_t MAIN_BUNDLE_ID;`
`2757`	`2757`	`public static std::unique_ptr<facebook::react::RAMBundleRegistry> multipleBundlesRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle, std::function<std::unique_ptr<facebook::react::JSModulesUnbundle>(std::string)> factory);`
`2758`		`- public static std::unique_ptr<facebook::react::RAMBundleRegistry> singleBundleRegistry(std::unique_ptr<facebook::react::JSModulesUnbundle> mainBundle);`
`2759`	`2758`	`public virtual ~RAMBundleRegistry() = default;`
`2760`	`2759`	`public void registerBundle(uint32_t bundleId, std::string bundlePath);`
`2761`	`2760`	`}`