Skip to content

Commit e1071ce

Browse files
jorge-cabfacebook-github-bot
authored andcommitted
Clean up legacy CSSBackgroundDrawable.java and enablNewBackgroundAndBorderDrawables featureflag (#53534)
Summary: Pull Request resolved: #53534 BackgroundDrawable and BorderDrawable have already substituted CSSBackgroundDrawable en every Android surface. - Deleting CSSBackgroundDrawable.java and its callsites - Deleting enableNewBackgroundAndDrawable featureflag Just cleaning up what at this point is just dead code. Changelog: [Internal] Reviewed By: javache Differential Revision: D81330969 fbshipit-source-id: bcf66ec8d3225802432ae1d93a2b26ea65cfcda0
1 parent b2b992c commit e1071ce

23 files changed

Lines changed: 109 additions & 1824 deletions

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<34c12f5a31aab5bfb874953f1beefef1>>
7+
* @generated SignedSource<<6a0977519362184efd85bd1807b2ad25>>
88
*/
99

1010
/**
@@ -222,12 +222,6 @@ public object ReactNativeFeatureFlags {
222222
@JvmStatic
223223
public fun enableNetworkEventReporting(): Boolean = accessor.enableNetworkEventReporting()
224224

225-
/**
226-
* Use BackgroundDrawable and BorderDrawable instead of CSSBackgroundDrawable
227-
*/
228-
@JvmStatic
229-
public fun enableNewBackgroundAndBorderDrawables(): Boolean = accessor.enableNewBackgroundAndBorderDrawables()
230-
231225
/**
232226
* Enables caching text layout artifacts for later reuse
233227
*/

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<392da016e0bf4193b72c44a508811e10>>
7+
* @generated SignedSource<<b9e541c9817e3ef4555ace90b7dfe821>>
88
*/
99

1010
/**
@@ -52,7 +52,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
5252
private var enableModuleArgumentNSNullConversionIOSCache: Boolean? = null
5353
private var enableNativeCSSParsingCache: Boolean? = null
5454
private var enableNetworkEventReportingCache: Boolean? = null
55-
private var enableNewBackgroundAndBorderDrawablesCache: Boolean? = null
5655
private var enablePreparedTextLayoutCache: Boolean? = null
5756
private var enablePropsUpdateReconciliationAndroidCache: Boolean? = null
5857
private var enableResourceTimingAPICache: Boolean? = null
@@ -378,15 +377,6 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
378377
return cached
379378
}
380379

381-
override fun enableNewBackgroundAndBorderDrawables(): Boolean {
382-
var cached = enableNewBackgroundAndBorderDrawablesCache
383-
if (cached == null) {
384-
cached = ReactNativeFeatureFlagsCxxInterop.enableNewBackgroundAndBorderDrawables()
385-
enableNewBackgroundAndBorderDrawablesCache = cached
386-
}
387-
return cached
388-
}
389-
390380
override fun enablePreparedTextLayout(): Boolean {
391381
var cached = enablePreparedTextLayoutCache
392382
if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<a0453230524ebca2bfb8fad656a6f54a>>
7+
* @generated SignedSource<<7b0b5efc545427de6f104cc36f42d0a9>>
88
*/
99

1010
/**
@@ -92,8 +92,6 @@ public object ReactNativeFeatureFlagsCxxInterop {
9292

9393
@DoNotStrip @JvmStatic public external fun enableNetworkEventReporting(): Boolean
9494

95-
@DoNotStrip @JvmStatic public external fun enableNewBackgroundAndBorderDrawables(): Boolean
96-
9795
@DoNotStrip @JvmStatic public external fun enablePreparedTextLayout(): Boolean
9896

9997
@DoNotStrip @JvmStatic public external fun enablePropsUpdateReconciliationAndroid(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<719706a983a073b6c286c49d993f7f80>>
7+
* @generated SignedSource<<7de4be16480ca4df9f2a6655a469c6c7>>
88
*/
99

1010
/**
@@ -87,8 +87,6 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
8787

8888
override fun enableNetworkEventReporting(): Boolean = false
8989

90-
override fun enableNewBackgroundAndBorderDrawables(): Boolean = true
91-
9290
override fun enablePreparedTextLayout(): Boolean = false
9391

9492
override fun enablePropsUpdateReconciliationAndroid(): Boolean = false

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<594815ba6a984c460ab8bddd91c5cae2>>
7+
* @generated SignedSource<<72146cdfb6cc16ead73858c970e4221a>>
88
*/
99

1010
/**
@@ -56,7 +56,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
5656
private var enableModuleArgumentNSNullConversionIOSCache: Boolean? = null
5757
private var enableNativeCSSParsingCache: Boolean? = null
5858
private var enableNetworkEventReportingCache: Boolean? = null
59-
private var enableNewBackgroundAndBorderDrawablesCache: Boolean? = null
6059
private var enablePreparedTextLayoutCache: Boolean? = null
6160
private var enablePropsUpdateReconciliationAndroidCache: Boolean? = null
6261
private var enableResourceTimingAPICache: Boolean? = null
@@ -414,16 +413,6 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
414413
return cached
415414
}
416415

417-
override fun enableNewBackgroundAndBorderDrawables(): Boolean {
418-
var cached = enableNewBackgroundAndBorderDrawablesCache
419-
if (cached == null) {
420-
cached = currentProvider.enableNewBackgroundAndBorderDrawables()
421-
accessedFeatureFlags.add("enableNewBackgroundAndBorderDrawables")
422-
enableNewBackgroundAndBorderDrawablesCache = cached
423-
}
424-
return cached
425-
}
426-
427416
override fun enablePreparedTextLayout(): Boolean {
428417
var cached = enablePreparedTextLayoutCache
429418
if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<dfbd5e84392f1fda0e68324582c328b2>>
7+
* @generated SignedSource<<47efc0544de6bdeec45ee4a7f1aa31fa>>
88
*/
99

1010
/**
@@ -87,8 +87,6 @@ public interface ReactNativeFeatureFlagsProvider {
8787

8888
@DoNotStrip public fun enableNetworkEventReporting(): Boolean
8989

90-
@DoNotStrip public fun enableNewBackgroundAndBorderDrawables(): Boolean
91-
9290
@DoNotStrip public fun enablePreparedTextLayout(): Boolean
9391

9492
@DoNotStrip public fun enablePropsUpdateReconciliationAndroid(): Boolean

0 commit comments

Comments
 (0)