Skip to content

Commit f0f71ea

Browse files
yungstersfacebook-github-bot
authored andcommitted
RN: Move {packages => private}/helloworld (#51934)
Summary: Pull Request resolved: #51934 Moves `packages/helloworld` to `private/helloworld`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D76356557 fbshipit-source-id: 92b20d75a8f2badb3c685d4918fe692623d9c04d
1 parent 85f0dec commit f0f71ea

73 files changed

Lines changed: 63 additions & 52 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.flowconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<PROJECT_ROOT>/packages/.*/dist
2828

2929
; helloworld
30-
<PROJECT_ROOT>/packages/helloworld/ios/Pods/
30+
<PROJECT_ROOT>/private/helloworld/ios/Pods/
3131

3232
; Ignore rn-tester Pods
3333
<PROJECT_ROOT>/packages/rn-tester/Pods/

.github/actions/test-ios-helloworld/action.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ runs:
5151
- name: Install iOS dependencies - Configuration ${{ inputs.flavor }};
5252
shell: bash
5353
run: |
54-
cd packages/helloworld
54+
cd private/helloworld
5555
args=()
5656
5757
if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
@@ -70,7 +70,7 @@ runs:
7070
fi
7171
7272
BUILD_TYPE="${{ inputs.flavor }}"
73-
TARBALL_FILENAME=$(node ../react-native/scripts/hermes/get-tarball-name.js --buildType "$BUILD_TYPE")
73+
TARBALL_FILENAME=$(node ../../packages/react-native/scripts/hermes/get-tarball-name.js --buildType "$BUILD_TYPE")
7474
export HERMES_ENGINE_TARBALL_PATH="$HERMES_WS_DIR/hermes-runtime-darwin/$TARBALL_FILENAME"
7575
export RCT_USE_LOCAL_RN_DEP="/tmp/third-party/ReactNativeDependencies${{ inputs.flavor }}.xcframework.tar.gz"
7676
@@ -79,13 +79,13 @@ runs:
7979
- name: Run Helloworld tests
8080
shell: bash
8181
run: |
82-
cd packages/helloworld
82+
cd private/helloworld
8383
yarn test
8484
8585
- name: Build HelloWorld project
8686
shell: bash
8787
run: |
88-
cd packages/helloworld
88+
cd private/helloworld
8989
9090
args=()
9191
if [[ ${{ inputs.flavor }} == "Release" ]]; then

.github/workflows/test-all.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ jobs:
533533
- name: Build the Helloworld application for ${{ matrix.flavor }} with Architecture set to New Architecture.
534534
shell: bash
535535
run: |
536-
cd packages/helloworld/android
536+
cd private/helloworld/android
537537
args=()
538538
if [[ ${{ matrix.flavor }} == "Release" ]]; then
539539
args+=(--prod)
@@ -543,7 +543,7 @@ jobs:
543543
uses: actions/upload-artifact@v4.3.4
544544
with:
545545
name: helloworld-apk-${{ matrix.flavor }}-NewArch-hermes
546-
path: ./packages/helloworld/android/app/build/outputs/apk/
546+
path: ./private/helloworld/android/app/build/outputs/apk/
547547
compression-level: 0
548548

549549
test_ios_helloworld_with_ruby_3_2_0:

.gitignore

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ project.xcworkspace
4040
/packages/react-native/ReactAndroid/external-artifacts/artifacts/
4141
/packages/react-native/ReactAndroid/hermes-engine/build/
4242
/packages/react-native/ReactAndroid/hermes-engine/.cxx/
43-
/packages/helloworld/android/app/build/
44-
/packages/helloworld/android/build/
43+
/private/helloworld/android/app/build/
44+
/private/helloworld/android/build/
4545
/packages/react-native-popup-menu-android/android/build/
4646
/packages/react-native-test-library/android/build/
4747

@@ -108,15 +108,15 @@ package-lock.json
108108

109109
# Ruby Gems (Bundler)
110110
/packages/react-native/vendor
111-
/packages/helloworld/vendor
111+
/private/helloworld/vendor
112112
.ruby-version
113113
/**/.ruby-version
114114
vendor/
115115

116116
# iOS / CocoaPods
117-
/packages/helloworld/ios/build/
118-
/packages/helloworld/ios/Pods/
119-
/packages/helloworld/ios/Podfile.lock
117+
/private/helloworld/ios/build/
118+
/private/helloworld/ios/Pods/
119+
/private/helloworld/ios/Podfile.lock
120120
/packages/rn-tester/bin/
121121
/packages/rn-tester/cache/
122122
/packages/rn-tester/extensions/

jest.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const {defaults} = require('jest-config');
1616

1717
const PODS_LOCATIONS = [
1818
'packages/rn-tester/Pods',
19-
'packages/helloworld/ios/Pods',
19+
'private/helloworld/ios/Pods',
2020
];
2121

2222
module.exports = {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"workspaces": [
4141
"packages/*",
4242
"private/*",
43-
"!packages/helloworld"
43+
"!private/helloworld"
4444
],
4545
"devDependencies": {
4646
"@babel/core": "^7.25.2",

0 commit comments

Comments
 (0)