VirtualViewContainerStateExperimental remove() memory leak fix (#54437)

CalixTang · meta-codesync[bot] · commit f2898d4b1629 · 2025-11-06T14:18:55.000-08:00
Summary: Pull Request resolved: #54437 ## Changelog: [Internal] VirtualView ID references (strings) are currently not being removed from the bookkeeping sets V, P, HPV in VirtualViewContainerStateExperimental upon deletion. This PR provides a fix by extending the parent container's `remove()` function and correctly removing the IDs from the bookkeeping sets. Reviewed By: yungsters Differential Revision: D86369358 fbshipit-source-id: de46cc5776ff465dd3c834a6eba6a9d1c460d2d8
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/VirtualViewContainerStateExperimental.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/VirtualViewContainerStateExperimental.kt
@@ -49,6 +49,13 @@ internal class VirtualViewContainerStateExperimental(scrollView: ViewGroup) :
     }
   }
 
+  override fun remove(virtualView: VirtualView) {
+    super.remove(virtualView)
+    HPV.remove(virtualView.virtualViewID)
+    P.remove(virtualView.virtualViewID)
+    V.remove(virtualView.virtualViewID)
+  }
+
   /**
    * Perform mode update check on a single VirtualView. Does not check other VirtualViews in the
    * collection. Use carefully

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,13 @@ internal class VirtualViewContainerStateExperimental(scrollView: ViewGroup) :`
`49`	`49`	`}`
`50`	`50`	`}`
`51`	`51`
	`52`	`+ override fun remove(virtualView: VirtualView) {`
	`53`	`+ super.remove(virtualView)`
	`54`	`+ HPV.remove(virtualView.virtualViewID)`
	`55`	`+ P.remove(virtualView.virtualViewID)`
	`56`	`+ V.remove(virtualView.virtualViewID)`
	`57`	`+ }`
	`58`	`+`
`52`	`59`	`/**`
`53`	`60`	`* Perform mode update check on a single VirtualView. Does not check other VirtualViews in the`
`54`	`61`	`* collection. Use carefully`