RN: Prohibit ESLint Warnings#51825
Closed
yungsters wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75988059 |
Summary: While testing D75988059 with D76047973, I noticed a few opportunities to improve the script used by `yarn lint-ci`: - The exit code does not currently propagate, meaning `lint-ci` will succeed when it shouldn't. - The shell script uses some non-idiomatic practices, so this improves it. Changelog: [Internal] Differential Revision: D76049502
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 5, 2025
Summary: Configures `yarn lint` to fail if there are any ESLint warnings. Changelog: [Internal] Reviewed By: kassens, NickGerleman Differential Revision: D75988059
yungsters
force-pushed
the
export-D75988059
branch
from
June 5, 2025 16:10
009ff70 to
831d918
Compare
Summary: Pull Request resolved: react#51825 Configures `yarn lint` to fail if there are any ESLint warnings. Changelog: [Internal] Reviewed By: kassens, NickGerleman Differential Revision: D75988059
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75988059 |
yungsters
force-pushed
the
export-D75988059
branch
from
June 5, 2025 16:15
831d918 to
d5bf94b
Compare
Contributor
|
This pull request has been merged in 0df71ea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Configures
yarn lintto fail if there are any ESLint warnings.Changelog:
[Internal]
Differential Revision: D75988059