Add test for onScroll events#51826
Closed
sammy-SC wants to merge 1 commit into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75899915 |
Summary: changelog: [internal] To make this possible, we "fake" a UI tick whenever `flushMessageQueue` is called. This was, after every JavaScript task a UI tick happens. Result: - Animations are setup right after mounting automatically. - Animation happens after Fantom.scrollTo is called. Reviewed By: lenaic Differential Revision: D75899915
sammy-SC
force-pushed
the
export-D75899915
branch
from
June 5, 2025 09:50
a9b2e18 to
64ecdc7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75899915 |
Contributor
|
This pull request has been merged in 5661fe9. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in 5661fe9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
To make this possible, we "fake" a UI tick whenever
flushMessageQueueis called. This was, after every JavaScript task a UI tick happens.Result:
Differential Revision: D75899915