Skip to content

Add test for onScroll events#51826

Closed
sammy-SC wants to merge 1 commit into
react:mainfrom
sammy-SC:export-D75899915
Closed

Add test for onScroll events#51826
sammy-SC wants to merge 1 commit into
react:mainfrom
sammy-SC:export-D75899915

Conversation

@sammy-SC

@sammy-SC sammy-SC commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Summary:
changelog: [internal]

To make this possible, we "fake" a UI tick whenever flushMessageQueue is called. This was, after every JavaScript task a UI tick happens.
Result:

  • Animations are setup right after mounting automatically.
  • Animation happens after Fantom.scrollTo is called.

Differential Revision: D75899915

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75899915

Summary:

changelog: [internal]

To make this possible, we "fake" a UI tick whenever `flushMessageQueue` is called. This was, after every JavaScript task a UI tick happens.
Result:
- Animations are setup right after mounting automatically.
- Animation happens after Fantom.scrollTo is called.

Reviewed By: lenaic

Differential Revision: D75899915
@sammy-SC
sammy-SC force-pushed the export-D75899915 branch from a9b2e18 to 64ecdc7 Compare June 5, 2025 09:50
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75899915

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 5, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in 5661fe9.

@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @sammy-SC in 5661fe9

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants