Skip to content

calculated scrollable range and bounds to prevent overscroll #51795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nohabean wants to merge 1 commit into from
+5 −1
Closed

calculated scrollable range and bounds to prevent overscroll #51795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ct-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,11 @@ private void recreateFlingAnimation(int scrollY) {
float direction = Math.signum(mScroller.getFinalY() - mScroller.getStartY());
float flingVelocityY = mScroller.getCurrVelocity() * direction;

mScroller.fling(getScrollX(), scrollY, 0, (int) flingVelocityY, 0, 0, 0, Integer.MAX_VALUE);
// Proposed fix to handle overscroll
int maxScrollY = computeVerticalScrollRange() - getHeight(); // Calculate the actual scrollable range
maxScrollY = Math.max(0, maxScrollY); // Calculate the max bound to prevent negative bounds

mScroller.fling(getScrollX(), scrollY, 0, (int) flingVelocityY, 0, 0, 0, maxScrollY);
} else {
scrollTo(getScrollX(), scrollY + (mScroller.getCurrX() - scrollerYBeforeTick));
}
Expand Down