Implement local connection for perf metrics in HostTarget#52838
Closed
huntie wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78904766 |
huntie
force-pushed
the
export-D78904766
branch
from
46bba21 to
cd4a12c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78904766 |
huntie
force-pushed
the
export-D78904766
branch
from
cd4a12c to
f9217a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78904766 |
huntie
force-pushed
the
export-D78904766
branch
2 times, most recently
from
1f6e13e to
8aa5a16
Compare
Summary: Pull Request resolved: #52838 **Context** Experimental V2 Performance Monitor prototype, beginning by bringing the [Interaction to Next Paint (INP)](https://web.dev/articles/inp) metric to React Native. **This diff** Wires up a client/subscriber for the `"__chromium_devtools_metrics_reporter"` runtime binding (to which we emit live metrics events since D78904748). This will be used to unpack these performance updates to send to the host platform. - Creates a new `HostRuntimeBinding` helper, which establishes a local/private CDP session. - Conditionally installs our perf metrics runtime binding in `HostTarget` when `perfMonitorV2Enabled` is set. - Wires up a new `onPerfMonitorUpdate` event on `HostTargetDelegate` (unimplemented until the next diff). Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D78904766
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78904766 |
huntie
force-pushed
the
export-D78904766
branch
from
8aa5a16 to
d2f9b2c
Compare
Contributor
|
This pull request has been merged in 2768c84. |
Collaborator
|
This pull request was successfully merged by @huntie in 2768c84 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Context
Experimental V2 Performance Monitor prototype, beginning by bringing the Interaction to Next Paint (INP) metric to React Native.
This diff
Wires up a client/subscriber for the
"__chromium_devtools_metrics_reporter"runtime binding (to which we emit live metrics events since D78904748). This will be used to unpack these performance updates to send to the host platform.HostRuntimeBindinghelper, which establishes a local/private CDP session.HostTargetwhenperfMonitorV2Enabledis set.onPerfMonitorUpdateevent onHostTargetDelegate(unimplemented until the next diff).Differential Revision: D78904766