Add Value override for has/get/setProperty#52910
Closed
tsaichien wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79120823 |
tsaichien
force-pushed
the
export-D79120823
branch
from
July 29, 2025 19:32
dfbd7bc to
0c150ae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79120823 |
tsaichien
force-pushed
the
export-D79120823
branch
from
July 29, 2025 19:36
0c150ae to
955dc22
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79120823 |
tsaichien
force-pushed
the
export-D79120823
branch
from
August 18, 2025 21:40
955dc22 to
ff0376a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79120823 |
tsaichien
force-pushed
the
export-D79120823
branch
from
August 18, 2025 21:44
ff0376a to
15d5588
Compare
tsaichien
force-pushed
the
export-D79120823
branch
from
August 27, 2025 23:35
15d5588 to
387611c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79120823 |
tsaichien
force-pushed
the
export-D79120823
branch
from
August 27, 2025 23:39
387611c to
5a2d9f0
Compare
tsaichien
force-pushed
the
export-D79120823
branch
from
August 28, 2025 22:26
5a2d9f0 to
50492c2
Compare
Summary: Pull Request resolved: react#52910 For `get/has/setProperty`, we should also be able to take in a generic JS Value as the property key. This change adds the Value overload for these APIs. The default implementation will use `Reflect.get`, `Reflect.has`, and `Reflect.set`. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D79120823
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79120823 |
tsaichien
force-pushed
the
export-D79120823
branch
from
August 28, 2025 22:30
50492c2 to
88c9a4f
Compare
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Aug 29, 2025
Summary: X-link: react/react-native#52910 For `get/has/setProperty`, we should also be able to take in a generic JS Value as the property key. This change adds the Value overload for these APIs. The default implementation will use `Reflect.get`, `Reflect.has`, and `Reflect.set`. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D79120823 fbshipit-source-id: 7e2e5ff1ca93397c549e7dd922797fe77aa97940
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Aug 29, 2025
Summary: X-link: react/react-native#52910 For `get/has/setProperty`, we should also be able to take in a generic JS Value as the property key. This change adds the Value overload for these APIs. The default implementation will use `Reflect.get`, `Reflect.has`, and `Reflect.set`. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D79120823 fbshipit-source-id: 7e2e5ff1ca93397c549e7dd922797fe77aa97940
Collaborator
|
This pull request was successfully merged by @tsaichien in b2d25c8 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in b2d25c8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For
get/has/setProperty, we should also be able to take in a genericJS Value as the property key. This change adds the Value overload for
these APIs.
The default implementation will use
Reflect.get,Object.hasOwn, andReflect.set.Reviewed By: lavenzg
Differential Revision: D79120823