Skip to content

Add NativeAnimated jest test to verify node creation behavior at update #53115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeyap wants to merge 1 commit into from
+253 −2
Closed

Add NativeAnimated jest test to verify node creation behavior at update #53115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
255 changes: 253 additions & 2 deletions packages/react-native/src/private/animated/__tests__/AnimatedNative-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,6 @@ describe('Native Animated', () => {
{type: 'addition', input: expect.any(Array)},
);
const additionCalls =
// $FlowFixMe[prop-missing]
// $FlowFixMe[prop-missing]
NativeAnimatedModule.createAnimatedNode.mock.calls.filter(
call => call[1].type === 'addition',
Expand All @@ -475,7 +474,6 @@ describe('Native Animated', () => {
const additionCall = additionCalls[0];
const additionNodeTag = additionCall[0];
const additionConnectionCalls =
// $FlowFixMe[prop-missing]
// $FlowFixMe[prop-missing]
NativeAnimatedModule.connectAnimatedNodes.mock.calls.filter(
call => call[1] === additionNodeTag,
Expand Down Expand Up @@ -1505,5 +1503,258 @@ describe('Native Animated', () => {
1,
);
});

it('creates new props, style and transform nodes at update', async () => {
const {Animated} = importModules();

const opacityA = new Animated.Value(0, {
debugID: 'opacityA',
useNativeDriver: true,
});
const opacityB = new Animated.Value(0, {
debugID: 'opacityB',
useNativeDriver: true,
});
opacityA.__makeNative();
opacityB.__makeNative();
const scaleA = new Animated.Value(0, {
debugID: 'scaleA',
useNativeDriver: true,
});
const scaleB = new Animated.Value(0, {
debugID: 'scaleB',
useNativeDriver: true,
});
scaleA.__makeNative();
scaleB.__makeNative();

expect(NativeAnimatedModule.createAnimatedNode).not.toHaveBeenCalled();

// 1. First render, both opacity and transform scale are managed by Animated
const root = await create(
<Animated.View
style={{opacity: opacityA, transform: [{scale: scaleA}]}}
/>,
);

let createAnimatedNodeCalledTimes = 0;
let dropAnimatedNodeCalledTimes = 0;

expect(
// $FlowFixMe[prop-missing]
NativeAnimatedModule.createAnimatedNode.mock.calls.slice(0, 5),
).toEqual([
[1, {debugID: 'opacityA', offset: 0, type: 'value', value: 0}],
[4, {debugID: 'scaleA', offset: 0, type: 'value', value: 0}],
[
3,
{
debugID: undefined,
transforms: [{nodeTag: 4, property: 'scale', type: 'animated'}],
type: 'transform',
},
],
[
2,
{
debugID: undefined,
style: {
opacity: 1,
transform: 3,
},
type: 'style',
},
],
[5, {debugID: undefined, props: {style: 2}, type: 'props'}],
]);

createAnimatedNodeCalledTimes += 5;

expect(NativeAnimatedModule.dropAnimatedNode).not.toHaveBeenCalled();
expect(NativeAnimatedModule.restoreDefaultValues).not.toHaveBeenCalled();
expect(
NativeAnimatedModule.disconnectAnimatedNodeFromView,
).not.toHaveBeenCalled();
expect(
NativeAnimatedModule.connectAnimatedNodeToView,
).toHaveBeenCalledTimes(1);

// 2. Update the Animated node to control opacity style
await update(
root,
<Animated.View
style={{opacity: opacityB, transform: [{scale: scaleA}]}}
/>,
);
jest.runAllTicks();

expect(
// $FlowFixMe[prop-missing]
NativeAnimatedModule.createAnimatedNode.mock.calls.slice(5, 9),
).toEqual([
[6, {debugID: 'opacityB', offset: 0, type: 'value', value: 0}],
// transform node is still recreated even though `scale` is unchanged
[
8,
{
debugID: undefined,
transforms: [{nodeTag: 4, property: 'scale', type: 'animated'}],
type: 'transform',
},
],
[
7,
{
debugID: undefined,
style: {
opacity: 6,
transform: 8,
},
type: 'style',
},
],
[9, {debugID: undefined, props: {style: 7}, type: 'props'}],
]);

createAnimatedNodeCalledTimes += 4;

expect(
// $FlowFixMe[prop-missing]
NativeAnimatedModule.dropAnimatedNode.mock.calls.slice(0, 4),
).toEqual([[1], [3], [2], [5]]);

dropAnimatedNodeCalledTimes += 4;

expect(NativeAnimatedModule.createAnimatedNode).toHaveBeenCalledTimes(
createAnimatedNodeCalledTimes,
);
expect(NativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(
dropAnimatedNodeCalledTimes,
);

expect(NativeAnimatedModule.restoreDefaultValues).toHaveBeenCalledTimes(
1,
);
expect(
NativeAnimatedModule.disconnectAnimatedNodeFromView,
).toHaveBeenCalledTimes(1);
expect(
NativeAnimatedModule.connectAnimatedNodeToView,
).toHaveBeenCalledTimes(2);

// 3. Opacity is controlled by React while transform scale is still managed by Animated
await update(
root,
<Animated.View style={{opacity: 1, transform: [{scale: scaleB}]}} />,
);
jest.runAllTicks();

expect(
// $FlowFixMe[prop-missing]
NativeAnimatedModule.createAnimatedNode.mock.calls.slice(9, 13),
).toEqual([
[10, {debugID: 'scaleB', offset: 0, type: 'value', value: 0}],
[
11,
{
debugID: undefined,
transforms: [{nodeTag: 10, property: 'scale', type: 'animated'}],
type: 'transform',
},
],
[
12,
{
debugID: undefined,
style: {
transform: 11,
},
type: 'style',
},
],
[13, {debugID: undefined, props: {style: 12}, type: 'props'}],
]);

createAnimatedNodeCalledTimes += 4;

expect(
// $FlowFixMe[prop-missing]
NativeAnimatedModule.dropAnimatedNode.mock.calls.slice(4, 9),
).toEqual([[6], [4], [8], [7], [9]]);

dropAnimatedNodeCalledTimes += 5;

expect(NativeAnimatedModule.createAnimatedNode).toHaveBeenCalledTimes(
createAnimatedNodeCalledTimes,
);
expect(NativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(
dropAnimatedNodeCalledTimes,
);
expect(NativeAnimatedModule.restoreDefaultValues).toHaveBeenCalledTimes(
2,
);
expect(
NativeAnimatedModule.disconnectAnimatedNodeFromView,
).toHaveBeenCalledTimes(2);
expect(
NativeAnimatedModule.connectAnimatedNodeToView,
).toHaveBeenCalledTimes(3);

// 4. Both opacity and transform scale are controlled by React instead of Animated
await update(
root,
<Animated.View style={{opacity: 1, transform: [{scale: 1}]}} />,
);
jest.runAllTicks();

{
const droppedTags = [10, 11, 12, 13];
for (let i = 0; i < droppedTags.length; i++) {
expect(NativeAnimatedModule.dropAnimatedNode).toHaveBeenNthCalledWith(
i + dropAnimatedNodeCalledTimes + 1,
droppedTags[i],
);
}

dropAnimatedNodeCalledTimes += droppedTags.length;
}
expect(NativeAnimatedModule.createAnimatedNode).toHaveBeenCalledTimes(
createAnimatedNodeCalledTimes,
);
expect(NativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(
dropAnimatedNodeCalledTimes,
);

// View is no longer connected to PropsAnimatedNode
expect(
NativeAnimatedModule.disconnectAnimatedNodeFromView,
).toHaveBeenCalledTimes(3);
expect(
NativeAnimatedModule.connectAnimatedNodeToView,
).toHaveBeenCalledTimes(3);
expect(NativeAnimatedModule.restoreDefaultValues).toHaveBeenCalledTimes(
3,
);

// 5. Unmount
await unmount(root);
jest.runAllTicks();
// No change for Animated nodes on unmount.
expect(NativeAnimatedModule.createAnimatedNode).toHaveBeenCalledTimes(
createAnimatedNodeCalledTimes,
);
expect(NativeAnimatedModule.dropAnimatedNode).toHaveBeenCalledTimes(
dropAnimatedNodeCalledTimes,
);
expect(
NativeAnimatedModule.disconnectAnimatedNodeFromView,
).toHaveBeenCalledTimes(3);
expect(
NativeAnimatedModule.connectAnimatedNodeToView,
).toHaveBeenCalledTimes(3);
expect(NativeAnimatedModule.restoreDefaultValues).toHaveBeenCalledTimes(
3,
);
});
});
});
Loading