Skip to content

Commit cb1ec84

Browse files
committed
fix empty blocks and typescript
1 parent 922847a commit cb1ec84

4 files changed

Lines changed: 12 additions & 3 deletions

File tree

packages/shared/src/client/drawer-button/drawer-button.test.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ import { DrawerButton } from "./drawer-button";
55
describe.concurrent("drawer-button", () => {
66
afterEach(cleanup);
77

8-
const dummyFunc = () => {};
8+
const dummyFunc = () => {
9+
// empty
10+
};
911
test("check if h1 heading exists", () => {
1012
render(<DrawerButton open setOpen={dummyFunc} />);
1113
});

scripts/manual-publish.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,11 @@ try {
140140
`gh release create ${NEW_VERSION} --generate-notes${
141141
isLatestRelease ? " --latest" : ""
142142
} -n "$(sed '1,/^## /d;/^## /,$d' lib/CHANGELOG.md)" --title "Release v${NEW_VERSION}"`,
143+
{ encoding: "utf8" },
143144
);
144-
} catch {}
145+
} catch {
146+
console.log("Failed to publish and/or create GitHub release");
147+
}
145148

146149
// Publish canonical packages
147150
execSync("tsx scripts/publish-canonical.ts");

scripts/publish.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,11 @@ if (isPatch) {
4545
try {
4646
execSync(
4747
`git checkout ${releaseBranch} && git merge ${BRANCH} && git push origin ${releaseBranch}`,
48+
{ encoding: "utf8" },
4849
);
49-
} catch {}
50+
} catch (err) {
51+
console.error("Error merging to release branch: ", err);
52+
}
5053
} else {
5154
try {
5255
updateSecurityMd(`${newMajor}.${newMinor}`, `${oldMajor}.${oldMinor}`);

scripts/rebrand.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,7 @@ const rebrandFn = async () => {
223223
delete rootPackageJSON.devDependencies.typedoc;
224224
Object.keys(rootPackageJSON.devDependencies).forEach((dep) => {
225225
if (dep.startsWith("typedoc-plugin-")) {
226+
// @ts-expect-error -- allow delete
226227
delete rootPackageJSON.devDependencies[dep];
227228
}
228229
});

0 commit comments

Comments
 (0)