Allow sending IRC topic changes to Discord#380
Open
twpol wants to merge 2 commits into
Open
Conversation
yuakihiro
reviewed
Oct 12, 2020
| "1234567890": "#channel" // Use a discord channel ID instead of its name (so you can rename it or to disambiguate) | ||
| }, | ||
| "channelTopicsToDiscord": [ // Sends topic changes from IRC to Discord | ||
| "#irc |
thezoggy
reviewed
Dec 12, 2025
| if (typeof this.channelTopicsToDiscord !== 'undefined') { | ||
| this.ircClient.on('topic', (channel, topic, nick, message) => { | ||
| if (message.command !== 'rpl_topicwhotime') { | ||
| logger.debug('Received topic change from IRC:', channel, topic); |
There was a problem hiding this comment.
to work with latest code needs to be updated to:
_logger.default.debug('Received topic change from IRC:', channel, topic);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the bot to send IRC topics from all channels (setting
true) or specific channels (settingArrayof names) through to Discord as a plain message like this:I had a go at sending Discord topics the other way but it didn't work, I think because it was trying to identify the author of the Discord event and there isn't one.
Part of #220