Release Candidate for 2.1.2: Update CI/CD actions and improve recv module documentation for next stable #551
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,7 +70,7 @@ jobs: | |
| printf "python-version=%s\n" "${{ steps.build-python.outputs.python-version }}" >> "$GITHUB_OUTPUT" | ||
| printf "PYTHON_VERSION=%s\n" "${{ steps.build-python.outputs.python-version }}" >> "$GITHUB_ENV" | ||
| printf "%s\n" "::endgroup::" | ||
| - uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5 | ||
| with: | ||
| path: ~/.cache/pip | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} | ||
|
|
@@ -123,7 +123,7 @@ jobs: | |
| - name: Upload build artifact | ||
| id: upload | ||
| if: ${{ !cancelled() && (steps.buildfiles.outputs.files != '') && (github.repository == 'reactive-firewall-org/multicast') }} | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| path: dist | ||
| name: multicast-build-${{ github.sha }} | ||
|
|
@@ -246,6 +246,7 @@ jobs: | |
| id-token: write | ||
| contents: read | ||
| attestations: write | ||
| artifact-metadata: write | ||
|
Contributor
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial 🧩 Analysis chain🌐 Web query:
💡 Result: No, actions/attest@v4.1.0 does not strictly require the artifact-metadata: write permission for core functionality (creating attestations). It requires id-token: write and attestations: write permissions. However, the artifact-metadata: write permission is required if you want to create an optional "artifact metadata storage record" (e.g., when using push-to-registry: true or create-storage-record: true). Without it, the action will warn but continue without creating the storage record. Citations:
The This permission is only needed if the attest action is configured with optional features such as 🤖 Prompt for AI Agents |
||
| needs: [BUILD] | ||
| runs-on: ubuntu-latest | ||
| environment: ${{ needs.BUILD.outputs.build_environment }} | ||
|
|
@@ -255,7 +256,7 @@ jobs: | |
| build-artifact-attestation-id: ${{ steps.multicast-build-attest.outputs.attestation-id }} | ||
| steps: | ||
| - name: Download All Artifacts | ||
| uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| path: ${{ github.workspace }}/dist | ||
| pattern: multicast-build-${{ github.sha }} | ||
|
|
@@ -266,14 +267,14 @@ jobs: | |
| - name: "Attest Build Checksums" | ||
| id: multicast-build-chksum-attest | ||
| if: ${{ !cancelled() && (github.repository == 'reactive-firewall-org/multicast') && (needs.BUILD.outputs.build_environment == 'Deployment' && startsWith(github.ref, 'refs/tags/v')) }} | ||
| uses: actions/attest@59d89421af93a897026c735860bf21b6eb4f7b26 # v4.1.0 | ||
| with: | ||
| subject-checksums: build.checksums.txt | ||
| github-token: ${{ github.token }} | ||
| - name: "Attest Build Artifact" | ||
| id: multicast-build-attest | ||
| if: ${{ !cancelled() && (github.repository == 'reactive-firewall-org/multicast') }} | ||
| uses: actions/attest@59d89421af93a897026c735860bf21b6eb4f7b26 # v4.1.0 | ||
| with: | ||
| subject-name: multicast-build-${{ github.sha }} | ||
| subject-digest: sha256:${{ needs.BUILD.outputs.artifact-digest }} | ||
|
|
@@ -338,15 +339,15 @@ jobs: | |
| printf "%s\n" "build_id=${{ github.run_id }}" >> "$GITHUB_OUTPUT" | ||
| cat <"$GITHUB_OUTPUT" >> "BUILD-info.txt" | ||
| - name: Download All Artifacts | ||
| uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| path: ${{ github.workspace }}/dist | ||
| pattern: multicast-build-${{ github.sha }} | ||
| merge-multiple: true | ||
| - name: Upload build summary | ||
| id: upload-build-info | ||
| if: ${{ !cancelled() && (github.repository == 'reactive-firewall-org/multicast') }} | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| path: "BUILD-info.txt" | ||
| name: multicast-info-${{ github.sha }} | ||
|
|
@@ -393,7 +394,7 @@ jobs: | |
| - name: Upload build summary | ||
| id: upload-build-summary | ||
| if: ${{ !cancelled() && (github.repository == 'reactive-firewall-org/multicast') }} | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| path: ./Build-Summary-Artifact.txt | ||
| name: BUILD-COMMENT-BODY-${{ github.sha }} | ||
|
|
@@ -414,7 +415,7 @@ jobs: | |
| - name: "Download Status Summary Artifact" | ||
| id: download-build-summary | ||
| if: ${{ !cancelled() && (github.repository == 'reactive-firewall-org/multicast') }} | ||
| uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| name: BUILD-COMMENT-BODY-${{ github.sha }} | ||
| github-token: ${{ github.token }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
inputs.workflow-run-idwhen rebuilding the fallback details URL.If
details-urlis omitted or rejected, Line 231 still points at the currentgithub.run_idinstead of the caller-suppliedworkflow-run-id. That yields a wrong check link as soon as this action is used to operate on a different workflow run.🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents