self review

Author: Archmonger

src/reactpy/core/hooks.py

@@ -215,8 +215,11 @@ def use_async_effect(
         shield:
             If ``True``, the effect will not be cancelled when the hook is running clean-up.
             This can be useful if you want to ensure that the effect runs to completion even if the
-            component is unmounted while the effect is still running (e.g. a database query).
-            However, use this option with caution as it can lead to memory leaks.
+            component is unmounted while the effect is still running (e.g. a multi-step database query).
+
+            Use this option with caution as it can lead to memory leaks if a faulty effect
+            stays alive indefinitely. If using this option, it is highly suggested to implement
+            your own timeout within the effect to mitigate this risk.
 
     Returns:
         If not function is provided, a decorator. Otherwise ``None``.

tests/test_core/test_events.py

@@ -714,6 +714,7 @@ async def test_controlled_input_default_debounce_prefers_latest_client_value(
     display: DisplayFixture,
 ):
     """Prefer the latest client value for a controlled input when using debounce, even if the server is still processing an older event."""
+
     @reactpy.component
     def ControlledInput():
         value, set_value = use_state("")

tests/test_reactjs/test_utils.py

@@ -190,6 +190,38 @@ def test_copy_file_fallback(tmp_path):
                         mock_rename.assert_called_once()
 
 
+def test_copy_file_symlink_falls_back_to_hard_link(tmp_path):
+    source = tmp_path / "source.txt"
+    source.write_text("content")
+    target = tmp_path / "target.txt"
+
+    path_cls = type(target)
+
+    with patch.object(path_cls, "symlink_to", side_effect=OSError):
+        with patch("os.link") as mock_link:
+            copy_file(target, source, symlink=True)
+
+    mock_link.assert_called_once_with(source, target)
+
+
+def test_copy_file_symlink_fallback_reraises_original_error(tmp_path):
+    source = tmp_path / "source.txt"
+    source.write_text("content")
+    target = tmp_path / "target.txt"
+
+    path_cls = type(target)
+    symlink_error = OSError("symlink failed")
+    hard_link_error = OSError("hard link failed")
+
+    with patch.object(path_cls, "symlink_to", side_effect=symlink_error):
+        with patch("os.link", side_effect=hard_link_error):
+            with pytest.raises(OSError) as exc_info:
+                copy_file(target, source, symlink=True)
+
+    assert exc_info.value is symlink_error
+    assert exc_info.value.__cause__ is hard_link_error
+
+
 def test_simple_file_lock_timeout(tmp_path):
     lock_file = tmp_path / "lock"