Commit 3c0aa37
committed
fix: restore Roslyn 4.8 band so .NET 8 SDK users work again
3.0.0 dropped the 4.8/4.12 analyzer bands, shipping only roslyn4.14 +
roslyn5.0. The compiler selects the highest analyzer band <= its own
Roslyn version, so every .NET 8 SDK (Roslyn 4.8 in 8.0.1xx through 4.11
in 8.0.4xx) found no matching band and the generators stopped loading;
the version-less code-fix assembly, built against 4.14, also tripped
CS9057. .NET 8 is supported through Nov 2026, so restore support:
- Re-add the generator's roslyn4.8 band, correctly pinned to
Microsoft.CodeAnalysis 4.8.0 (the old Roslyn480 project had no
VersionOverride and silently resolved to 4.14 under CPM). The 4.12+
API surface stays compiled out via the absent ROSYLN_412 constant.
- Pin the version-less code-fix assembly to 4.8.0 as well. It loads on
every host, and building against the oldest supported API keeps it
forward-compatible (4.8 -> 5.0) with no CS9057, so -warnaserror .NET 8
builds are unaffected.
- Pack three bands: roslyn4.8 (whole .NET 8 line + VS 17.12/17.13),
roslyn4.14 (VS 17.14 / .NET 9), roslyn5.0 (VS 2026 / .NET 10).
- Drop the EOL net9 MAUI sample TFMs (net10 only).
Build + 891 tests green on net8/9/10; pack verified to contain
analyzers/dotnet/roslyn4.8/cs.1 parent 7f3d743 commit 3c0aa37
6 files changed
Lines changed: 75 additions & 20 deletions
File tree
- src
- ReactiveUI.SourceGenerators.Analyzers.CodeFixes
- ReactiveUI.SourceGenerators.Roslyn480
- ReactiveUI.SourceGenerators
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
82 | 83 | | |
83 | | - | |
| 84 | + | |
84 | 85 | | |
85 | | - | |
| 86 | + | |
86 | 87 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
20 | 25 | | |
21 | | - | |
22 | | - | |
23 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
24 | 29 | | |
25 | 30 | | |
26 | 31 | | |
| |||
Lines changed: 42 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
38 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
39 | 44 | | |
| 45 | + | |
40 | 46 | | |
41 | 47 | | |
42 | 48 | | |
| |||
0 commit comments