Replace deprecated Page.DisplayAlert with Shell.Current.DisplayAlert in MAUI sample#4320
Merged
glennawatson merged 2 commits intocleanup/remove-old-integration-testsfrom Apr 2, 2026
Conversation
Agent-Logs-Url: https://github.com/reactiveui/ReactiveUI/sessions/6ba4073e-9c47-41d8-9caf-abe1e86fd740 Co-authored-by: glennawatson <5834289+glennawatson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix deprecated API call in comments
Replace deprecated Apr 2, 2026
Page.DisplayAlert with Shell.Current.DisplayAlert in MAUI sample
glennawatson
approved these changes
Apr 2, 2026
glennawatson
pushed a commit
that referenced
this pull request
Apr 3, 2026
…rt` in MAUI sample (#4320)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page.DisplayAlertis marked obsolete in MAUI 10. The MAUI sample'sLoginPagewas calling the instance method directly instead of routing throughShell.Current.Changes
src/examples/ReactiveUI.Samples.Maui/LoginPage.xaml.cs: Replaceawait DisplayAlert(...)withawait (Shell.Current?.DisplayAlert(...) ?? Task.CompletedTask), using the null-conditional to guard againstShell.Currentbeing null at call time.