Skip to content

perf: use custom reactive sinks to improve allocations and performance#4363

Merged
glennawatson merged 70 commits into
mainfrom
glennawatson/update-analyzers
May 25, 2026
Merged

perf: use custom reactive sinks to improve allocations and performance#4363
glennawatson merged 70 commits into
mainfrom
glennawatson/update-analyzers

refactor: reuse shared Select/Choose sinks to remove duplication

13c7da9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 25, 2026 in 0s

89.93% (+0.03%) compared to b37934c

View this Pull Request on Codecov

89.93% (+0.03%) compared to b37934c

Details

Codecov Report

❌ Patch coverage is 81.85993% with 316 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.93%. Comparing base (b37934c) to head (13c7da9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ReactiveUI.Wpf/Binding/ValidationBindingWpf.cs 16.66% 34 Missing and 1 partial ⚠️
...rc/ReactiveUI/Activation/CanActivateViewFetcher.cs 55.55% 22 Missing and 2 partials ⚠️
...UI/Bindings/Command/CommandBinderImplementation.cs 71.08% 22 Missing and 2 partials ⚠️
...eUI/Bindings/Converter/ComponentModelConversion.cs 44.73% 17 Missing and 4 partials ⚠️
src/ReactiveUI.Maui/ReactiveImageItemView.cs 60.00% 11 Missing and 3 partials ⚠️
src/ReactiveUI.Maui/RoutedViewHost.cs 87.61% 10 Missing and 3 partials ⚠️
src/ReactiveUI.Maui/RoutedViewHost{TViewModel}.cs 87.61% 10 Missing and 3 partials ⚠️
...rc/ReactiveUI.Winforms/ActivationForViewFetcher.cs 67.50% 9 Missing and 4 partials ⚠️
...ctiveUI.Blazor/Internal/ViewModelReactivitySink.cs 71.42% 6 Missing and 6 partials ⚠️
src/ReactiveUI.Maui/ReactiveTextItemView.cs 53.84% 10 Missing and 2 partials ⚠️
... and 34 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4363      +/-   ##
==========================================
+ Coverage   89.90%   89.93%   +0.03%     
==========================================
  Files         254      365     +111     
  Lines        9656    15645    +5989     
  Branches     1480     1614     +134     
==========================================
+ Hits         8681    14070    +5389     
- Misses        730     1217     +487     
- Partials      245      358     +113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov